Repository navigation
Makes the live datamodel pane follow the scrubber - #189
Merged
Merged
Conversation
The live inspector's scrubber moved the diagram, the note and the event log to a selected macrostep, while its datamodel pane kept folding the whole stream. The updater now hands the pane the same selection the other panes read, so on a selected macrostep it shows the values as they stood at the end of that macrostep, and Live returns it to the current values - as the persisted stepper already did. A test drives the updater over a chart whose datamodel moves and reads the rendered pane at First and at Live. The notebook's scrubber step and the Kino moduledoc say the pane follows; a Changed fragment carries the host-facing line. Refs: sui-25h
johnnyt
force-pushed
the
sui-25h-live-datamodel-pane-follows-scrubber
branch
from
October 11, 2026 14:54
6b68558 to
e6eca1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: sui-25h
What
The live inspector's scrubber (
StatifierUI.Kino.inspect/3) moved the diagram, the selection note and the event log to a selected macrostep, while its datamodel pane kept folding the whole stream and showed the live tip's values. Whether the pane should follow was ruled by the operator, 2026-10-10: the pane follows the scrubber, a test pins it, and the notebook note says so.StatifierUI.Kino.Updater's render passes the pane the same options the note, diagram and log panes already read, soStatifierUI.Inspector.datamodel/2folds under the current selection. On a selected macrostep the pane shows the values as they stood at the end of that macrostep; on Live it shows the current values, byte-identical to what it rendered before. The persisted stepper (StatifierUI.Kino.TraceStepper) already did this.notebooks/inspector.livemd, step 6: the paragraph that said the explorer does not move with the scrubber now says it does, and what to expect at |< First and on Live.changelog.d/sui-25h.md, Changed: "The live inspector's datamodel pane (StatifierUI.Kino.inspect/3) follows its scrubber: on a selected macrostep it shows the values as they stood at the end of that macrostep, and Live returns it to the current values."Nothing else the inspector answers changes: every
StatifierUI.Inspectorfunction is untouched, and the pane's output at the live tip is what it was.Test
A new describe in
test/statifier_ui/kino_test.exsdrives the updater over a live session on the test module's counter chart (its datamodel moves on every event), scrubs to First and back to Live, and compares the text the datamodel frame holds withInspector.datamodel/2at macrostep 1 and at the tip; the two readings differ, so the frame can only match one of them.Sabotage (recorded above the test): the updater's datamodel render was put back to
Inspector.datamodel/1with no options in a copy-backed file; the new test failed on its first frame assertion, the pane showing the tip's count where the first macrostep's was expected, and the file's other tests passed. The file was restored byte-equal and recompiled before the gate.Provenance
notebooks/inspector.livemd, step 10: its first item said the stepper's datamodel pane moves "unlike step 6", which this change makes false; it now reads "as in step 6". The brief named only step 6's paragraph.Gate
Full
mix qualitygreen on this head, attested bymix quality.verify.Review
Cold tier: this PR changes a documented live behaviour, so the review pass is dispatched separately. No record text in this PR.