Repository navigation
Pins the library cases' send types - #454
Merged
Merged
Conversation
conformance/README.md says every library-world case whose chart sends registers both send types, library:timer then library:route, but no test read host.send_types: a case registering only one of them, or the two in the other order, passed every test. - Adds a test to test/corpus/corpus_files_test.exs that reads every committed case under conformance/cases/library/, accepts/ and diff/ (the three directories the README places in the library world) and asserts that each one with a host object carries send_types exactly ["library:timer", "library:route"]. It refuses to pass vacuously when no such case is found. - Swapping the two types in one committed library case turns it red, as does dropping library:route; each was restored from a copy, byte-equal, and the test is green again. Test only; no changelog fragment. Full mix quality (mix gate.verify) ran green on this commit's tree (write-tree 5d5a189). Refs: st-sm5s
johnnyt
force-pushed
the
st-sm5s-library-send-types-test
branch
from
October 11, 2026 16:03
8b48f5e to
8f90b9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: st-sm5s
What this adds
conformance/README.md's library-world section says every library casewhose chart sends registers both send types,
library:timerthenlibrary:route, and that a case whose chart sends nothing carries nohostobject. No test read
host.send_types: the existing host test intest/corpus/corpus_files_test.exsasserts that a case whose document sendscarries a host object, and nothing checked what that object registers. A
library case registering only
library:timer, or the two types in the otherorder, passed every test.
The new test in the same file reads every committed case JSON under
conformance/cases/library/,accepts/anddiff/(the three directoriesthe README places in the library world), keeps those with a
hostobject,and asserts that each carries
send_typesexactly["library:timer", "library:route"], naming any case that does not. Itfails when it finds no such case, so it cannot pass on nothing. The cases
under
send/andsystem_variables/keep their own domain, as the READMEsays, and are not read. A library case added later is covered without a
change here.
The sabotage checks
Each in
conformance/cases/library/loan_lost_after_timer.json, the filecopied first:
case and
["library:route", "library:timer"];library:routedropped: the test fails on its assertion, naming the caseand
["library:timer"].After each, the file was restored from the copy and confirmed byte-equal
(
cmp, andgit diff --exit-code), and the test passed again. The testasserts committed case files and no
lib/behaviour, so its# sabotage:line states the exemption and names these two mutations.
Test only; no changelog fragment (
changelog.d/README.mdexcludes the testharness and conformance fixtures).
Gate
Full
mix quality(mix gate.verify) green on this commit's tree after therebase onto the current
main, and the merge profile(
mix quality --profile merge) green, the ADR judge skipped because no fileis in a judged scope.
Review
Tier: gate (a test over committed fixtures). The in-turn review of the diff
found nothing to change.