Fix/zoom wheel delta scaling#35
Open
Ni55aN wants to merge 2 commits into
Open
Conversation
Remove stale eslint-disable comments and fix void-expression warnings from rete lint --fix. Co-authored-by: Cursor <cursoragent@cursor.com>
Scale wheel input by deltaMode, cap steps at intensity to preserve mouse wheel behavior, and skip zero deltas. Add zoom unit and handler tests. Fixes #31 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes jitter when zooming with a touchpad pinch while zoom restrictions are enabled (#31).
After #32, wheel zoom used
Math.sign(deltaY)only — any non-zerodeltaYtriggered a full±intensitystep. Touchpad pinch sends small fractional values (e.g.0.01–3), so each micro-movement caused a full zoom step and visible jitter at min/max zoom bounds.This PR:
deltaYviadeltaMode(PIXEL / LINE ×8 / PAGE ×24) inzoom-wheel.tsintensity(one mouse wheel click ≈ one step)deltaY === 0(gesture end / horizontal wheel)zoom-wheel.test.ts) and handler tests (zoom.test.ts) covering mouse, touchpad, and edge casesMouse behavior is unchanged: large wheel deltas (Chrome ~120px, Firefox 1 line) still produce
±intensityper click.Also includes a separate commit with lint auto-fixes (
style: apply lint auto-fixes) and addsnpm testscript.Related Issues
#31
Checklist
Additional Notes