Skip to content

fix: Preserve explicit zero timedelta values in discovery manifests #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hnicke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Preserve explicit zero timedelta values in discovery manifests #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions python/restate/discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,14 +346,16 @@ def compute_discovery(endpoint: RestateEndpoint, discovered_as: typing.Literal["
description=handler.description,
metadata=handler.metadata,
inactivityTimeout=int(handler.inactivity_timeout.total_seconds() * 1000)
if handler.inactivity_timeout
if handler.inactivity_timeout is not None
else None,
abortTimeout=int(handler.abort_timeout.total_seconds() * 1000)
if handler.abort_timeout is not None
else None,
abortTimeout=int(handler.abort_timeout.total_seconds() * 1000) if handler.abort_timeout else None,
journalRetention=int(handler.journal_retention.total_seconds() * 1000)
if handler.journal_retention
if handler.journal_retention is not None
else None,
idempotencyRetention=int(handler.idempotency_retention.total_seconds() * 1000)
if handler.idempotency_retention
if handler.idempotency_retention is not None
else None,
workflowCompletionRetention=int(handler.workflow_retention.total_seconds() * 1000)
if handler.workflow_retention
Expand Down Expand Up @@ -394,14 +396,16 @@ def compute_discovery(endpoint: RestateEndpoint, discovered_as: typing.Literal["
description=description,
metadata=metadata,
inactivityTimeout=int(service.inactivity_timeout.total_seconds() * 1000)
if service.inactivity_timeout
if service.inactivity_timeout is not None
else None,
abortTimeout=int(service.abort_timeout.total_seconds() * 1000)
if service.abort_timeout is not None
else None,
abortTimeout=int(service.abort_timeout.total_seconds() * 1000) if service.abort_timeout else None,
journalRetention=int(service.journal_retention.total_seconds() * 1000)
if service.journal_retention
if service.journal_retention is not None
else None,
idempotencyRetention=int(service.idempotency_retention.total_seconds() * 1000)
if service.idempotency_retention
if service.idempotency_retention is not None
else None,
enableLazyState=service.enable_lazy_state if isinstance(service, (Workflow, VirtualObject)) else None,
ingressPrivate=service.ingress_private,
Expand Down
Loading