Open
Conversation
pcholakov
force-pushed
the
pavel/swvrymnouvuo
branch
2 times, most recently
from
f6d8e20 to
07720f7
Compare
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
sounds good, i would put the key snippet in the docs
pcholakov
force-pushed
the
pavel/swvrymnouvuo
branch
from
07720f7 to
a423407
Compare
- Use TextMapGetter in extractTraceContext so all propagator formats (W3C, B3, Jaeger) work without hardcoding header names - Explain in README why Node.js auto-instrumentation can't substitute for manual extraction: Restate wraps the HTTP transport layer and handlers replay, so one span per logical invocation requires extracting from ctx.request().attemptHeaders - Remove committed screenshot (trace.png); add *.png to .gitignore
pcholakov
force-pushed
the
pavel/swvrymnouvuo
branch
from
a423407 to
42f8fef
Compare
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
I'm back on this PR review, testing few things :)
Can you please move the whole example down in typescript/integrations/tracing?
pcholakov
force-pushed
the
pavel/swvrymnouvuo
branch
from
42f8fef to
95c86fb
Compare
Contributor
|
cc @nikrooz once you finish with the tracing PR, you have the example ready to adapt here :) |
slinkydeveloper
force-pushed
the
pavel/swvrymnouvuo
branch
from
95c86fb to
841faa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.