initialize state with all elements that appear in GEN-INFO blocks not…#222
Open
rburghol wants to merge 14 commits intorespec:developfrom
Open
initialize state with all elements that appear in GEN-INFO blocks not…#222rburghol wants to merge 14 commits intorespec:developfrom
rburghol wants to merge 14 commits intorespec:developfrom
Conversation
… just OPN SEQUENCE
rburghol
pushed a commit
to HARPgroup/HSPsquared
that referenced
this pull request
Feb 5, 2026
Member
|
@rburghol , you are reading that right. If a user wants to remove an operation from a simulation, it is legitimate and common for instance to 'comment out' that line of the OPN SEQUENCE block and then every occurrence of that operation is ignored throughout the UCI. |
Contributor
Author
|
Thanks @PaulDudaRESPEC - so then any special actions that refer to things that are NOT in the IF you could confirm that logic I'd appreciate it (or disabuse me of my errors). |
Member
|
@rburghol , I confirm that logic. |
This comment was marked as outdated.
This comment was marked as outdated.
added 12 commits
February 5, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PaulDudaRESPEC This is OK to merge (all tests passed). This fixes an error reported in #179 where a
SPEC-ACTIONSwas looking for aRCHRESthat did not exist in state. As it turns out, this was not really aSPEC-ACTIONSexecution error, but rather something that should have been caught earlier in the runtime setup forSPEC-ACTIONS:HSPFbehavior only items in theOPN SEQUENCEblock are loaded at runtime byHSP2but convention allowed segments in GEN-INFO blocks to remain as inactive.GEN-INFOentries, but would would not allowSPEC-ACTIONSto reference inactive segments.Exception: Missing/inactive segment RCHRES 110 referenced in SPECIAL ACTIONS. Quitting.