feat(webhooks): add support for topic and contact.topics.updated events - #291
Merged
joaopcm merged 3 commits intoSep 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
klotty
approved these changes
Sep 29, 2026
klotty
left a comment
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds TypedDicts, event-list entries, exports, and a version bump for four webhook events the API already emits. This is an additive, non-breaking SDK typing change; remaining risk is ordinary typing correctness already covered by Cubic's review.
Re-trigger cubic
dielduarte
approved these changes
Sep 29, 2026
joaopcm
deleted the
feature/dev-2239-python-sdk-internal-squad-devtools
branch
September 29, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the API accepts
contact.topics.updated,topic.created,topic.updatedandtopic.deletedas webhook events, and they're live with no feature flag (the monorepo has sent them since at least60ac6d5dbf, 2026-02-12).resend.Webhooksdoesn't list them andWebhookEventPayloadhas no types for them.this adds them to the event list in
_webhook.py, addsContactTopicsEventData,ContactTopicSubscription,TopicEventData,ContactTopicsUpdatedEvent,TopicCreatedEvent,TopicUpdatedEventandTopicDeletedEvent, and exports them.topicsitems are a newContactTopicSubscription, withsubscriptiontyped asLiteral["opt_in", "opt_out"].payloads, from
topic-events-webhook.tsandcontact-events-webhook.tsin the monorepo:contact.topics.updated:email, andtopics, the topics changed in that update, each with its newsubscription(opt_inoropt_out)topic.created,topic.updated,topic.deleted:id,name,description(string ornull),default_subscription(opt_inoropt_out),deleted,created_at,updated_atbumps to
2.49.0.flake8 and pytest (699 passed) pass. mypy has 2 errors, both
Unused "type: ignore"intests/exceptions_test.py:136,139, andmainhas the same 2.