feat: add partially_verified and partially_failed to DomainRecordStatus type#941
Draft
feat: add partially_verified and partially_failed to DomainRecordStatus type#941
partially_verified and partially_failed to DomainRecordStatus type#941Conversation
…us type Add 'partially_verified' and 'partially_failed' as possible values for the DomainRecordStatus type to align with the domain verification statuses returned by the API. Co-authored-by: Vitor Capretz <capretzvitor@gmail.com>
Contributor
|
@vcapretz No please do not. This will be a regression. A Domain Record can not be. Only a domain can. We finally fixed all the inconsistencies we had in this PR, so this is the correct behavior. https://resend.slack.com/archives/C08HL2WMU73/p1776428952919899 @Vitor Capretz remember? Still asked for your advice on that one, please have a very close look before/if you change things. My recommendation is not. The API + SDKs are now doing what the Docs have always said it, it is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
partially_verifiedandpartially_failedas possible values for theDomainRecordStatustype, aligning it with the statuses the API can actually return for domain verification records.The
DomainStatustype already included these values, butDomainRecordStatus(used for individual DNS record verification statuses like SPF, DKIM, Tracking, etc.) was missing them.Before
After
All existing tests pass (343 tests across 30 test files).
Slack Thread
Summary by cubic
Add
partially_verifiedandpartially_failedtoDomainRecordStatusto match API responses for DNS record verification. This avoids type mismatches and enables handling partial states for records like SPF, DKIM, and Tracking.Written for commit 555dfcc. Summary will update on new commits.