Skip to content

feat: add partially_verified and partially_failed to DomainRecordStatus type#941

Draft
vcapretz wants to merge 1 commit intocanaryfrom
cursor/add-partial-record-statuses-eab6
Draft

feat: add partially_verified and partially_failed to DomainRecordStatus type#941
vcapretz wants to merge 1 commit intocanaryfrom
cursor/add-partial-record-statuses-eab6

Conversation

@vcapretz
Copy link
Copy Markdown
Contributor

@vcapretz vcapretz commented Apr 22, 2026

Summary

Adds partially_verified and partially_failed as possible values for the DomainRecordStatus type, aligning it with the statuses the API can actually return for domain verification records.

The DomainStatus type already included these values, but DomainRecordStatus (used for individual DNS record verification statuses like SPF, DKIM, Tracking, etc.) was missing them.

Before

export type DomainRecordStatus =
  | 'pending'
  | 'verified'
  | 'failed'
  | 'temporary_failure'
  | 'not_started';

After

export type DomainRecordStatus =
  | 'pending'
  | 'verified'
  | 'failed'
  | 'temporary_failure'
  | 'not_started'
  | 'partially_verified'
  | 'partially_failed';

All existing tests pass (343 tests across 30 test files).

Slack Thread

Open in Web Open in Cursor 

Summary by cubic

Add partially_verified and partially_failed to DomainRecordStatus to match API responses for DNS record verification. This avoids type mismatches and enables handling partial states for records like SPF, DKIM, and Tracking.

  • Migration
    • Update switch/if logic and type guards to handle the two new statuses.
    • Adjust UI/metrics mapping for the new partial statuses if applicable.

Written for commit 555dfcc. Summary will update on new commits.

…us type

Add 'partially_verified' and 'partially_failed' as possible values for
the DomainRecordStatus type to align with the domain verification
statuses returned by the API.

Co-authored-by: Vitor Capretz <capretzvitor@gmail.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@rehanvdm
Copy link
Copy Markdown
Contributor

@vcapretz No please do not. This will be a regression.

A Domain Record can not be. Only a domain can.
| 'partially_verified'
| 'partially_failed';

We finally fixed all the inconsistencies we had in this PR, so this is the correct behavior. https://resend.slack.com/archives/C08HL2WMU73/p1776428952919899

@Vitor Capretz remember? Still asked for your advice on that one, please have a very close look before/if you change things. My recommendation is not.

The API + SDKs are now doing what the Docs have always said it, it is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants