Skip to content

Fix jsx completion for abstract Jsx.component - #8526

Draft
aspeddro wants to merge 2 commits into
rescript-lang:masterfrom
aspeddro:fix-lsp-completion
Draft

Fix jsx completion for abstract Jsx.component#8526
aspeddro wants to merge 2 commits into
rescript-lang:masterfrom
aspeddro:fix-lsp-completion

Conversation

@aspeddro

@aspeddro aspeddro commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8526

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8526

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8526

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8526

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8526

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8526

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8526

commit: 0a140c3

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.70%. Comparing base (2f97455) to head (0a140c3).

Files with missing lines Patch % Lines
analysis/src/completion_jsx.ml 35.29% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8526      +/-   ##
==========================================
- Coverage   74.70%   74.70%   -0.01%     
==========================================
  Files         458      458              
  Lines       62366    62363       -3     
==========================================
- Hits        46593    46589       -4     
- Misses      15773    15774       +1     
Files with missing lines Coverage Δ
analysis/src/completion_jsx.ml 72.38% <35.29%> (-2.62%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant