Skip to content

Change return type of Intl.Collator.compare to Ordering.t #8289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 2 commits into from
Mar 12, 2026
+4 −2
Merged

Change return type of Intl.Collator.compare to Ordering.t #8289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9d321f
Change return type of Intl.Collator.compare to Ordering.t
cknitt Mar 11, 2026
2d779da
CHANGELOG
cknitt Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#### :boom: Breaking Change

- Change `Intl.Collator.compare` return type from `int` to `Ordering.t` (`float`). https://github.com/rescript-lang/rescript/pull/8289

#### :eyeglasses: Spec Compliance

#### :rocket: New Feature
Expand Down
4 changes: 2 additions & 2 deletions packages/@rescript/runtime/Stdlib_Intl_Collator.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ Intl.Collator.resolvedOptions(collator).locale == "en-US"

```rescript
let collator = Intl.Collator.make(~locales=["en-US"])
collator->Intl.Collator.compare("apple", "banana") < 0
Ordering.isLess(collator->Intl.Collator.compare("apple", "banana"))
```
*/
@send external compare: (t, string, string) => int = "compare"
@send external compare: (t, string, string) => Stdlib_Ordering.t = "compare"

/**
`ignore(collator)` ignores the provided collator and returns unit.
Expand Down
Loading