Repository navigation
Conversation
Signed-off-by: Glenn Slotte <glenn@slotte.net>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 793aa1c908
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| module Toggle = { | ||
| type tag = JsxEvent.Toggle.tag |
There was a problem hiding this comment.
When this package is compiled with the currently supported ReScript 13.0.0-alpha.5, this member does not exist: JsxEvent.Toggle is introduced by compiler PR 9075, while package.json and package-lock.json remain on alpha.5 and the changelog still declares alpha.5 as the minimum. Because the npm package ships its .res and .resi sources, consumers on the allowed minimum cannot compile a release containing this binding; update the compiler requirement, lockfile, and documented minimum to the first release that includes that compiler change.
Useful? React with 👍 / 👎.
Expose typed
oldState,newState, and optionalsourceaccessors alongside the standard synthetic-event helpers.Based on React DOM 19.3.1’s SyntheticEvent.js and the documented
ToggleEvent.sourcebehavior.Depends on rescript-lang/rescript#9075