Split playground into workspace packages#1278
Draft
jderochervlk wants to merge 1 commit intovlk/monorepo-foundationfrom
Draft
Split playground into workspace packages#1278jderochervlk wants to merge 1 commit intovlk/monorepo-foundationfrom
jderochervlk wants to merge 1 commit intovlk/monorepo-foundationfrom
Conversation
Move shared editor/compiler helpers into @rescript-lang/shared and the playground implementation into @rescript-lang/playground. Wire the docs app to consume both workspace packages and keep playground browser storage access safe during prerendering.
cb52ca9 to
9788098
Compare
Cloudflare deploymentDeployement ID: 96e51657-991d-4c3c-b130-4aa8308d8a70 ⛅️ wrangler 4.85.0 ✨ Uploading _redirects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is stacked on top of
vlk/monorepo-foundationand prepares the docs/playground split needed forguide.rescript-lang.org.Summary
packages/sharedfor reusable editor/compiler helpers such as CodeMirror, HighlightJs, Semver, icons, text components, and compiler API bindings.packages/playgroundfor the current playground implementation and its direct runtime/editor dependencies.apps/docsto depend on@rescript-lang/sharedand@rescript-lang/playgroundthrough the workspace graph./trydoes not accesswindowat build time.workspace:*dependencies.Verification
yarn build:resyarn build:scriptsyarn build:update-indexyarn build:viteyarn ci:formatyarn vitest --browser.headless --runyarn testoutside the sandboxFormat,Site_Checks,Vitest,Deploy,E2E Tests