[codex] simplify landing page DOM structure#1272
[codex] simplify landing page DOM structure#1272jderochervlk wants to merge 5 commits intomasterfrom
Conversation
Simplify the landing page markup by removing single-child wrappers and moving layout classes onto the surviving elements where needed. Add responsive visual snapshots for the major landing page sections at desktop, tablet, and mobile widths so the refactor has a stable regression baseline.
Render the full landing page in browser tests and target section roots by data-testid instead of route helper exports. Refresh the existing landing page snapshots and increase the mobile viewport height so tall sections capture without extra white space.
Clone selected landing page sections into a top-level sandbox before screenshotting so Vitest captures the component instead of page scroll context. Refresh the landing page snapshots and add the page-level getByTestId binding used by the new harness.
Mirror the landing page highlight.js registration in browser tests. Add regression coverage for highlighted playground code in the live render and sandboxed snapshot copy.
Render selected landing sections inside a normal test wrapper before capturing screenshots. Refresh the affected landing-page screenshots so the playground hero retains syntax highlighting in the stored baselines.
Cloudflare deploymentDeployement ID: 4946c2e9-ee68-4072-8b20-5ad1a54fc269 ⛅️ wrangler 4.63.0 (update available 4.85.0) ✨ Uploading _redirects |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06c4fc19d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Refactor the landing page route to remove unnecessary wrapper elements and keep layout styles on the surviving DOM nodes.
What Changed
Why
The landing page had several inert wrapper nodes that made the markup noisier and harder to reason about. This reduces DOM depth while keeping the rendered layout stable.
Impact
Validation
yarn build:resyarn vitest __tests__/LandingPage_.test.jsx --browser.headless --run