Skip to content

[ONCALL-280] fix: requestly collections partially importing in local workspace#283

Open
wrongsahil wants to merge 1 commit intomasterfrom
fix-requestly-collections-not-importing-in-local-fs
Open

[ONCALL-280] fix: requestly collections partially importing in local workspace#283
wrongsahil wants to merge 1 commit intomasterfrom
fix-requestly-collections-not-importing-in-local-fs

Conversation

@wrongsahil
Copy link
Member

@wrongsahil wrongsahil commented Feb 9, 2026

Root cause: When header, query params or path params existed without id or isEnabled, it was leading to request getting not imported.

[
                {
                    "key": "Accept",
                    "isEnabled": true,
                    "value": "application/json"
                }
            ],

Summary by CodeRabbit

  • Bug Fixes
    • Fixed validation requirements for HTTP headers and query parameters to support optional identifier and enabled status fields, allowing greater flexibility in request configuration.

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Walkthrough

This PR modifies the KeyValuePair schema in src/renderer/actions/local-sync/schemas.ts by making two fields optional: the id field and the isEnabled field. Both fields transition from required types to optional types. This change affects the validation and structure of KeyValuePair objects used in HTTP headers, query parameters, and request body structures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • nsrCodes
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: fixing requestly collections that were partially importing in local workspace by making KeyValuePair fields optional.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-requestly-collections-not-importing-in-local-fs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wrongsahil wrongsahil changed the title fix: requestly collections partially importing in local workspace [ONCALL-280] fix: requestly collections partially importing in local workspace Feb 9, 2026
@linear
Copy link

linear bot commented Feb 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant