-
Notifications
You must be signed in to change notification settings - Fork 45
[ENGG-5080] chore: Updated the structure of the readme. #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
WalkthroughThe README.md was edited to pluralize the main heading, adjust capitalization and phrasing in prerequisites, bump the Node.js requirement from 16.15.0 to 18.18.0 (NPM version unchanged), and substantially reorganize the Development/Run/Setup flow. The prior top-level cloning of requestly-proxy was removed and replaced with a simplified local npm install/start sequence, while an expanded optional section describes cloning and running requestly-proxy with platform-specific watch instructions. The Packaging section was updated to show Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
release/app/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
README.md(2 hunks)
🔇 Additional comments (3)
README.md (3)
47-48: Verify Node.js version bump and update npm version guidance.The Node.js version bump from 16.15.0 to 18.18.0 is a breaking change for users on Node 16. While 18.18.0 is a reasonable modern LTS, ensure this version constraint is intentional and necessary for the codebase.
Additionally, npm 8.5.5 (from 2022) is significantly outdated. Current npm versions are 10+. Consider either updating the npm version requirement to align with modern releases or removing the constraint if it's not critical.
50-50: Verify external documentation link.The link to requestly/requestly repo's README should be validated to ensure it remains accessible and points to the correct resource.
Please confirm the link is valid and points to the current proxy setup documentation.
28-28: Excellent structural and clarity improvements.The grammar fixes ("network requests" plural, proper articles, consistent capitalization), section reorganization, and conversion of nested steps to sub-steps (a, b, c) substantially improve documentation readability and consistency. The proxy setup instructions are now explicit and well-formatted with proper code fencing.
Also applies to: 45-45, 53-101
README.md Improvements
Grammar & Wording Fixes
Changed "Debug your network request" to "Debug your network requests" (plural form)
Added article "a" to "You should have a web app server running locally"
Replaced ampersands (&) with "and" for better readability
Changed "Locally" to lowercase "locally" for consistency
Fixed capitalization: "start watching" → "Start watching"
Formatting & Structure Enhancements
Converted nested steps under item 4 (requestly-proxy setup) from inconsistent numbering (1-3) to properly formatted sub-steps (a, b, c)
Improved parenthetical note formatting for better readability
Added colon after section descriptions for consistency
Added sh language specifier to the Packaging code block for consistency with other code blocks
Punctuation & Clarity
Added missing period after "Follow this [step]" link
Changed "then follow the following steps" to "follow these steps:" (clearer, less repetitive)
Improved note formatting: "Press" → "press" for consistency with surrounding text
All changes maintain the original intent and structure while improving readability, consistency, and professional presentation of the documentation.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.