Switch from context manager to a straight binding to avoid deadlock#143
Merged
blast-hardcheese merged 1 commit intomainfrom Mar 18, 2025
Merged
Switch from context manager to a straight binding to avoid deadlock#143blast-hardcheese merged 1 commit intomainfrom
blast-hardcheese merged 1 commit intomainfrom
Conversation
jackyzha0
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Attempting to run
uv run pytest -k test_ignore_flood_subscriptionhangs for a significant amount of time.This is because in
__aexit__we await on the server'swait_closed(), which never completes because we still haven't calledserver.close():An alternate approach would be to wrap the entire innards of the async context in a
try: ... finally: server.close().What changed
Reflowed
clientservertext fixture to avoid a deadlock.Test plan
CI