Repository navigation
Conversation
Assisted-by: Replit
Assisted-by: Replit
Assisted-by: Replit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the worker-daemon build path for consumers of dynamic derivations.
The evaluator already supports
builtins.outputOf, but the worker client discardedrealized output paths and later queried the unresolved derivation for them.
BuildPathsWithResults.dynamicOutputsin derivation JSON.Direct dynamic output strings as installables remain unsupported; consumers such
as drvgo's wrapper derivations are supported. No evaluator-time builds are added.
Validation
cargo clippy --all-targets -- -D warnings, formatting, and ast-grep passed.bench/results/dynamic-upm.md. The VM could not enable Nix sandboxing.Text and test evidence are used because this is a CLI/daemon protocol change.
~ written by ⠕ Replit