Conversation
There was a problem hiding this comment.
Files would auto download instead of opening on GitHub.
This is a patch.
| [SemaphoreCI](<https://semaphoreci.com/>). | ||
|
|
||
| ℹ️ _Are you using **Gitlab**? Have a look at [this example](./gitlab_capybara_selenium.md) instead (and elaborate)._ | ||
| > _Are you using **Gitlab**? Have a look at [this example](./gitlab_capybara_selenium.md) instead (and elaborate)._ |
There was a problem hiding this comment.
yes, github has a default syntax for that
| e.g. `renuo create-deploio-app my-app git@github.com:renuo/my-app.git` | ||
| e.g: | ||
| ```sh | ||
| renuo create-deploio-app my-app git@github.com:renuo/my-app.git` |
There was a problem hiding this comment.
Fence allows copy-pasting via button
| @@ -1,6 +1,6 @@ | |||
| # Devise | |||
|
|
|||
| :warning: If you are going to use devise we suggest you to [send_emails](send_emails.md) first. :warning: | |||
There was a problem hiding this comment.
Wasn't rendering properly on mdbook
There was a problem hiding this comment.
I see, use the github ones: https://github.com/orgs/community/discussions/16925
| let(:wallee_transaction_id) { "194681414" } | ||
|
|
||
| it "goes the 😊 path" do | ||
| it "goes the happy path" do |
There was a problem hiding this comment.
I remember that this was causing issues with the derived VCR cassette name.
| - [Getting Started](ruby_on_rails/README.md) | ||
|
|
||
| - [Setup]() | ||
| - [Step 1: Create the App]() |
There was a problem hiding this comment.
I think using "Step 1", "Step 2" makes the setup guide a lot easier to follow
lukasbischof
left a comment
There was a problem hiding this comment.
Thanks for your efforts to optimise this guides, I think it's nice to streamline the process a bit and I like the new structure 👍
| * Run `bin/setup` | ||
|
|
||
| * Then check your default Rails setup by running `bin/run` and visiting http://[project-name].localhost:3000. | ||
| * Then check your default Rails setup by running `bin/run` and visiting [http://[project-name].localhost:3000](http://[project-name].localhost:3000). |
There was a problem hiding this comment.
Not sure if this link makes sense, it's invalid and that's a guide so you're reading it
| By now `rails new` has already initialised the local git repository and created an initial commit for you. This step pushes that commit to the GitHub repository you created in the [previous step](../create_git_repository.md). | ||
|
|
||
| After creating the repo you can connect your project to the remote git repo (if you didn't use `hub create` command) | ||
| If you used `hub create -p renuo/[project-name]`, the `origin` remote is already set. Otherwise, add it: |
There was a problem hiding this comment.
Why don't we incentivise to use gh repo create?
There was a problem hiding this comment.
gh repo create renuo/[my-project] --private --source=.
There was a problem hiding this comment.
Yes I agree, let's update it
| Some services should be configured accordingly to the packages bought by the customer. | ||
| Once the new application is created, please add the project to the |
There was a problem hiding this comment.
That's still valid, isn't it?
| * SEO | ||
| * redirect non-www to www | ||
| * Header tags | ||
| * [Wicked PDF](wicked_pdf.md) `gem wicked_pdf` |
There was a problem hiding this comment.
Generally not sure if we should still recommend wicked_pdf… It's based on wkhtmltopdf which was archived in 2023 and generally does not support a lot of css features
| if ARGV == ["supports", "html"] | ||
| exit 0 | ||
| end | ||
|
|
||
| _context, book = JSON.parse($stdin.read) | ||
| book["sections"].each { |section| walk(section) } | ||
| puts JSON.generate(book) |
There was a problem hiding this comment.
I have no clue what you're doing here 😅
| * Continuous deployment (*CD*) ready and running for both branches | ||
| * The application deployed for both branches | ||
|
|
||
| As an appendix, you'll find a [checklist](checklist.md) you can use to follow the guide. |
|
|
||
| We want you to know exactly the reason behind each single step of this guide. | ||
|
|
||
| Thank you for your work and have fun! :tada: |
There was a problem hiding this comment.
No more fun allowed either xD
| - [Getting Started](ruby_on_rails/README.md) | ||
|
|
||
| - [Setup]() | ||
| - [Step 1: Create the App]() |
There was a problem hiding this comment.
Why are these links leading to nowhere?
| - [Create a GitHub Repository](create_git_repository.md) | ||
| - [Push to Git Repository](ruby_on_rails/first_git_push.md) | ||
| - [Initialise Gitflow](ruby_on_rails/initialise_gitflow.md) | ||
| - [Configure Git Repository](configure_git_repository.md) |
There was a problem hiding this comment.
Wouldn't the steps be initialise git repo, configure gitflow (do we even need the git extension?), create and configure github repo
There was a problem hiding this comment.
i agree
- git push
- git repository
coorasse
left a comment
There was a problem hiding this comment.
Nice work.
There some parts that I'd like to keep for historical reasons and some rephrasings I do not approve, but overall the changes are good. Can you please extract the emoji changes in a separate PR? They have nothing to do with the rest and we can get them merged separately. Some separate things (an agent will do this for you in a minute):
- mdbook changes and fixes (also make sure the readme command works)
- emojis
- warnings,notes,and other sections normalized with github formatting
- content
I'd like this PR to contain only the changes to the actual content, so I can review the last two files. Thanks!
| * Run `bin/setup` | ||
|
|
||
| * Then check your default Rails setup by running `bin/run` and visiting http://[project-name].localhost:3000. | ||
| * Then check your default Rails setup by running `bin/run` and visiting [http://[project-name].localhost:3000](http://[project-name].localhost:3000). |
| This document will try to be as minimalist as possible and provide you with all the steps to set up the application as | ||
| fast as possible. There are things, in Renuo projects, which are mandatory, other that are suggested. | ||
| This guide is the result of more than ten years of experience, so this means three things: it's very robust, very opinionated, and possibly very outdated. |
There was a problem hiding this comment.
this was a very important note to explain how this guide was born and evolved. I'd not drop it.
| If you are reading this document, it means that you have to setup a new application. | ||
| A new project started and it's now time to set everything up so that **everyone**, | ||
| in your team, **can start working on it**. |
There was a problem hiding this comment.
this is also important introduction about what will happen and the main purpose
| The guide is structured as a linear walkthrough. Follow it from top to bottom when setting up a new project. | ||
|
|
||
| **You are always welcome to challenge the guide and improve it with a Pull Request.** | ||
| 1. **Before You Start** — Read [Naming Conventions](naming_conventions.md), [GitFlow](gitflow.md), and [Security](security.md) to understand the ground rules. |
There was a problem hiding this comment.
I think you should read the naming convention when you need to give a name to the project. It's of no use at this step, without a purpose. This is covered by the first step in the rails part of the guide.
Knowing giflow is, instead, important, but I don't think it should actually be part of this guide, but of the wiki.
Security is also important but it tells me things I cannot yet do since I don't have a repo, so it should rather be at the very end.
| **You are always welcome to challenge the guide and improve it with a Pull Request.** | ||
| 1. **Before You Start** — Read [Naming Conventions](naming_conventions.md), [GitFlow](gitflow.md), and [Security](security.md) to understand the ground rules. | ||
| 2. **Rails Application Setup** — Follow the [step-by-step setup](ruby_on_rails/README.md) to create, deploy, and configure your app. | ||
| 3. **Guides & Recipes** — Pick the ones you need (emails, authentication, payment, etc.). |
There was a problem hiding this comment.
this will slow down the application setup. It's more important to go ahead and setup everything that is mandatory. When the project is ready, everyone can start working and you can go through the optional parts
| **Note:** If you are using Heroku, the latest Ruby / node version may not yet | ||
| be available on their platform, so you may need to delay the upgrade. Check the | ||
| following GitHub repositories to see if Heroku added support already: | ||
| > **Note:** If you are using Heroku, the latest Ruby / node version may not yet |
There was a problem hiding this comment.
| > **Note:** If you are using Heroku, the latest Ruby / node version may not yet | |
| > **Note:** If you are using Heroku or Deploio, the latest Ruby / node version may not yet |
| @@ -1,6 +1,6 @@ | |||
| # Devise | |||
|
|
|||
| :warning: If you are going to use devise we suggest you to [send_emails](send_emails.md) first. :warning: | |||
There was a problem hiding this comment.
I see, use the github ones: https://github.com/orgs/community/discussions/16925
| By now `rails new` has already initialised the local git repository and created an initial commit for you. This step pushes that commit to the GitHub repository you created in the [previous step](../create_git_repository.md). | ||
|
|
||
| After creating the repo you can connect your project to the remote git repo (if you didn't use `hub create` command) | ||
| If you used `hub create -p renuo/[project-name]`, the `origin` remote is already set. Otherwise, add it: |
| git add . | ||
| git commit -m "Initial commit" | ||
| git push -u origin main |
There was a problem hiding this comment.
I am surprised that this is not needed. I haven't double-checked myself, but is strange.
There was a problem hiding this comment.
next time, do the emoji changes in a separate PR, so we can get those merged. They have nothing to do with the content change and they are distracting a lot.

Linearize the guide so setup reads top-to-bottom without backtracking.
As this PR strongly leans onto
mdbook, I recommend reviewing it beyond the markdown.Notes
SUMMARY.md+ Rails README into 5 sequential steps: Create → Deploy → Quality → Monitoring → Customer Plan.first_git_push.mdbacktrack and the redundant "Initial commit" (rails newalready commits).<…>so mdbook renders them as links.:tada:/:warning:shortcodes with Unicode emoji (mdbook doesn't expand GFM shortcodes).bin/mdbook-rewrite-linkspreprocessor to sendtemplates/*non-.mdlinks to GitHub blob URLs.emojitsuCI step, pinned mdbook to 0.4.40.