Skip to content

Linearize ASG among other improvements#442

Open
cb341 wants to merge 17 commits intomainfrom
feature/improve-docs
Open

Linearize ASG among other improvements#442
cb341 wants to merge 17 commits intomainfrom
feature/improve-docs

Conversation

@cb341
Copy link
Copy Markdown
Contributor

@cb341 cb341 commented Apr 22, 2026

Linearize the guide so setup reads top-to-bottom without backtracking.
As this PR strongly leans onto mdbook, I recommend reviewing it beyond the markdown.

Notes

  • Reorganized SUMMARY.md + Rails README into 5 sequential steps: Create → Deploy → Quality → Monitoring → Customer Plan.
  • Dropped the first_git_push.md backtrack and the redundant "Initial commit" (rails new already commits).
  • Wrapped bare URLs in <…> so mdbook renders them as links.
  • Replaced :tada: / :warning: shortcodes with Unicode emoji (mdbook doesn't expand GFM shortcodes).
  • Unified note/warning blockquote style and the ⭐️ "template-provided" marker.
  • Added bin/mdbook-rewrite-links preprocessor to send templates/* non-.md links to GitHub blob URLs.
  • Dropped the emojitsu CI step, pinned mdbook to 0.4.40.

@cb341 cb341 self-assigned this Apr 22, 2026
Comment thread bin/mdbook-rewrite-links
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files would auto download instead of opening on GitHub.
This is a patch.

[SemaphoreCI](<https://semaphoreci.com/>).

ℹ️ _Are you using **Gitlab**? Have a look at [this example](./gitlab_capybara_selenium.md) instead (and elaborate)._
> _Are you using **Gitlab**? Have a look at [this example](./gitlab_capybara_selenium.md) instead (and elaborate)._
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes should be defined in a consistent manner:

Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, github has a default syntax for that

e.g. `renuo create-deploio-app my-app git@github.com:renuo/my-app.git`
e.g:
```sh
renuo create-deploio-app my-app git@github.com:renuo/my-app.git`
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fence allows copy-pasting via button

Comment thread ruby_on_rails/devise.md
@@ -1,6 +1,6 @@
# Devise

:warning: If you are going to use devise we suggest you to [send_emails](send_emails.md) first. :warning:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't rendering properly on mdbook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread ruby_on_rails/wallee.md
let(:wallee_transaction_id) { "194681414" }

it "goes the 😊 path" do
it "goes the happy path" do
Copy link
Copy Markdown
Contributor Author

@cb341 cb341 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that this was causing issues with the derived VCR cassette name.

Comment thread SUMMARY.md
- [Getting Started](ruby_on_rails/README.md)

- [Setup]()
- [Step 1: Create the App]()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using "Step 1", "Step 2" makes the setup guide a lot easier to follow

@cb341 cb341 changed the title Linearize ASG Linearize ASG + other improvements Apr 22, 2026
@cb341 cb341 marked this pull request as ready for review April 22, 2026 21:47
@cb341 cb341 changed the title Linearize ASG + other improvements Linearize ASG among other improvements Apr 22, 2026
@cb341 cb341 requested a review from lukasbischof April 23, 2026 08:55
Copy link
Copy Markdown
Member

@lukasbischof lukasbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts to optimise this guides, I think it's nice to streamline the process a bit and I like the new structure 👍

* Run `bin/setup`

* Then check your default Rails setup by running `bin/run` and visiting http://[project-name].localhost:3000.
* Then check your default Rails setup by running `bin/run` and visiting [http://[project-name].localhost:3000](http://[project-name].localhost:3000).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this link makes sense, it's invalid and that's a guide so you're reading it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fair

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

By now `rails new` has already initialised the local git repository and created an initial commit for you. This step pushes that commit to the GitHub repository you created in the [previous step](../create_git_repository.md).

After creating the repo you can connect your project to the remote git repo (if you didn't use `hub create` command)
If you used `hub create -p renuo/[project-name]`, the `origin` remote is already set. Otherwise, add it:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the heck is hub?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we incentivise to use gh repo create?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh repo create renuo/[my-project] --private --source=.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, let's update it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please. switch to gh

Comment thread ruby_on_rails/README.md
Comment on lines -45 to -46
Some services should be configured accordingly to the packages bought by the customer.
Once the new application is created, please add the project to the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still valid, isn't it?

Comment thread ruby_on_rails/README.md
* SEO
* redirect non-www to www
* Header tags
* [Wicked PDF](wicked_pdf.md) `gem wicked_pdf`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally not sure if we should still recommend wicked_pdf… It's based on wkhtmltopdf which was archived in 2023 and generally does not support a lot of css features

Comment thread bin/mdbook-rewrite-links
Comment on lines +33 to +39
if ARGV == ["supports", "html"]
exit 0
end

_context, book = JSON.parse($stdin.read)
book["sections"].each { |section| walk(section) }
puts JSON.generate(book)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue what you're doing here 😅

Comment thread README.md
* Continuous deployment (*CD*) ready and running for both branches
* The application deployed for both branches

As an appendix, you'll find a [checklist](checklist.md) you can use to follow the guide.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more checklist?

Comment thread README.md

We want you to know exactly the reason behind each single step of this guide.

Thank you for your work and have fun! :tada:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more fun allowed either xD

Comment thread SUMMARY.md
- [Getting Started](ruby_on_rails/README.md)

- [Setup]()
- [Step 1: Create the App]()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these links leading to nowhere?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are headings

Comment thread SUMMARY.md
Comment on lines +17 to 20
- [Create a GitHub Repository](create_git_repository.md)
- [Push to Git Repository](ruby_on_rails/first_git_push.md)
- [Initialise Gitflow](ruby_on_rails/initialise_gitflow.md)
- [Configure Git Repository](configure_git_repository.md)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the steps be initialise git repo, configure gitflow (do we even need the git extension?), create and configure github repo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree

  1. git push
  2. git repository

@cb341 cb341 requested a review from coorasse April 23, 2026 14:01
Copy link
Copy Markdown
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
There some parts that I'd like to keep for historical reasons and some rephrasings I do not approve, but overall the changes are good. Can you please extract the emoji changes in a separate PR? They have nothing to do with the rest and we can get them merged separately. Some separate things (an agent will do this for you in a minute):

  • mdbook changes and fixes (also make sure the readme command works)
  • emojis
  • warnings,notes,and other sections normalized with github formatting
  • content

I'd like this PR to contain only the changes to the actual content, so I can review the last two files. Thanks!

* Run `bin/setup`

* Then check your default Rails setup by running `bin/run` and visiting http://[project-name].localhost:3000.
* Then check your default Rails setup by running `bin/run` and visiting [http://[project-name].localhost:3000](http://[project-name].localhost:3000).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Comment thread README.md
Comment on lines -16 to -18
This document will try to be as minimalist as possible and provide you with all the steps to set up the application as
fast as possible. There are things, in Renuo projects, which are mandatory, other that are suggested.
This guide is the result of more than ten years of experience, so this means three things: it's very robust, very opinionated, and possibly very outdated.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a very important note to explain how this guide was born and evolved. I'd not drop it.

Comment thread README.md
Comment on lines -12 to -14
If you are reading this document, it means that you have to setup a new application.
A new project started and it's now time to set everything up so that **everyone**,
in your team, **can start working on it**.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also important introduction about what will happen and the main purpose

Comment thread README.md
The guide is structured as a linear walkthrough. Follow it from top to bottom when setting up a new project.

**You are always welcome to challenge the guide and improve it with a Pull Request.**
1. **Before You Start** — Read [Naming Conventions](naming_conventions.md), [GitFlow](gitflow.md), and [Security](security.md) to understand the ground rules.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should read the naming convention when you need to give a name to the project. It's of no use at this step, without a purpose. This is covered by the first step in the rails part of the guide.

Knowing giflow is, instead, important, but I don't think it should actually be part of this guide, but of the wiki.

Security is also important but it tells me things I cannot yet do since I don't have a repo, so it should rather be at the very end.

Comment thread README.md
**You are always welcome to challenge the guide and improve it with a Pull Request.**
1. **Before You Start** — Read [Naming Conventions](naming_conventions.md), [GitFlow](gitflow.md), and [Security](security.md) to understand the ground rules.
2. **Rails Application Setup** — Follow the [step-by-step setup](ruby_on_rails/README.md) to create, deploy, and configure your app.
3. **Guides & Recipes** — Pick the ones you need (emails, authentication, payment, etc.).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will slow down the application setup. It's more important to go ahead and setup everything that is mandatory. When the project is ready, everyone can start working and you can go through the optional parts

Comment thread ruby_on_rails/depfu.md
**Note:** If you are using Heroku, the latest Ruby / node version may not yet
be available on their platform, so you may need to delay the upgrade. Check the
following GitHub repositories to see if Heroku added support already:
> **Note:** If you are using Heroku, the latest Ruby / node version may not yet
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note:** If you are using Heroku, the latest Ruby / node version may not yet
> **Note:** If you are using Heroku or Deploio, the latest Ruby / node version may not yet

Comment thread ruby_on_rails/devise.md
@@ -1,6 +1,6 @@
# Devise

:warning: If you are going to use devise we suggest you to [send_emails](send_emails.md) first. :warning:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By now `rails new` has already initialised the local git repository and created an initial commit for you. This step pushes that commit to the GitHub repository you created in the [previous step](../create_git_repository.md).

After creating the repo you can connect your project to the remote git repo (if you didn't use `hub create` command)
If you used `hub create -p renuo/[project-name]`, the `origin` remote is already set. Otherwise, add it:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please. switch to gh

Comment on lines -15 to 14
git add .
git commit -m "Initial commit"
git push -u origin main
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised that this is not needed. I haven't double-checked myself, but is strange.

Comment thread ruby_on_rails/hotjar.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time, do the emoji changes in a separate PR, so we can get those merged. They have nothing to do with the content change and they are distracting a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants