This repository was archived by the owner on Jun 17, 2025. It is now read-only.
Integrated Jest and full test coverage for all exposed API methods #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovatorruler
commented
Dec 2, 2020
renovatorruler
commented
- Added jest and tests for all exposed API methods
- Added ESLINT for standard coding convention
- Minor update in the documentation regarding the smartTradesV2 method
- Other minor changes (commented in the PR)
added 15 commits
December 1, 2020 00:46
- Added index.test.js - Added jest and jeft-fetch-mock to package.json
… feature/02-integrate-jest
- Updated yarn.lock
- More tests
- fixed imports issue in index.test.js
renovatorruler
commented
Dec 2, 2020
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| API_URL: 'https://api.3commas.io' | |||
Author
There was a problem hiding this comment.
Moved API_URL attributes into its own file (primarily for easier testing)
renovatorruler
commented
Dec 2, 2020
| }, | ||
| "author": "Rento", | ||
| "license": "gpl-3.0", | ||
| "license": "GPL-3.0-only", |
Author
There was a problem hiding this comment.
Changed the license field value it to valid SPDX expression. Please review.
renovatorruler
commented
Dec 2, 2020
Comment on lines
+1
to
+3
| language: node_js | ||
| node_js: | ||
| - 10 |
Author
There was a problem hiding this comment.
Added .travis.yml, so now you can integrate it with TravisCI and it will run the whole set of tests with every PR.
renovatorruler
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.