fix: encode parentheses in the deep link URLs - #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Open in ChatGPT and Open in Cursor links rendered their entire URL-encoded prompt as visible text on the page.
Cause: encodeURIComponent does not escape parentheses, and the prompt contains "Rendobar (https://rendobar.com)". In markdown, the first raw ) inside text closes the link early, so everything after it rendered as body text. There were 47 raw parens in each URL.
Fix: percent-encode ( and ) as %28 and %29 when building the links. Both lines now contain exactly the two structural markdown parens, and the URLs round-trip: decoding the query back yields the canonical prompt byte for byte (3651 chars both ways). Cursor URL is 5101 chars, inside its 8000 cap.
Reported from the live page.