Skip to content

Simplify SxPB setup parsing to requests-only format#1

Merged
grencez merged 1 commit intotrunkfrom
codex/pluralize-request-field-in-setup
Feb 23, 2026
Merged

Simplify SxPB setup parsing to requests-only format#1
grencez merged 1 commit intotrunkfrom
codex/pluralize-request-field-in-setup

Conversation

@gendeux
Copy link

@gendeux gendeux commented Feb 23, 2026

Motivation

  • The SxPB test fixtures were fully pluralized to use setup.requests, so the test harness should stop supporting the legacy singular setup.request fallback.
  • Removing the ad-hoc list normalization simplifies the test code and avoids divergent handling for request vs requests fields.

Description

  • Updated test/server_test.py to iterate only over setup.requests via for req in cast(List[Dict[str, Any]], setup_block.get("requests", [])) and removed the singular fallback.
  • Removed the normalize_list helper and its usages, and made request/response values handling use the raw values field directly.
  • Updated test/server_test_cases.sxpb to replace all setup.request instances with setup.requests using the SxPB list form so fixtures and test harness match.

Testing

  • Ran pytest -q and confirmed all tests passed: 8 passed.

Codex Task

@grencez grencez force-pushed the codex/pluralize-request-field-in-setup branch from 7ef0d47 to b240774 Compare February 23, 2026 16:43
Co-authored-by: Codex <codex@openai.com>
@grencez grencez force-pushed the codex/pluralize-request-field-in-setup branch from b240774 to 006151b Compare February 23, 2026 16:45
@grencez grencez changed the title Simplify SXPB setup parsing to requests-only format Simplify SxPB setup parsing to requests-only format Feb 23, 2026
@grencez grencez merged commit 006151b into trunk Feb 23, 2026
6 checks passed
@grencez grencez deleted the codex/pluralize-request-field-in-setup branch February 23, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants