Repository navigation
GH-34: serve queries from a per-process in-memory index - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Replaces the on-disk bleve/bbolt search index with a per-process in-memory index (
bleve.NewMemOnly), eliminating the cross-instance index flock that permanently hard-failedquery_knowledgewithErrIndexLockedwhen a second knowledge-mcp instance was alive.Changes
search.Indexis now a thin in-memory wrapper (search.NewIndex()); queries block on a ready channel until the backgroundIndexAllcompletes (same cold-start semantics)search.Location, lazy open, lock waits, staleness metadata, corruption recovery; removedsearch/location.go,search/location_test.go,search/race_test.go--indexand--no-index-on-startupare accepted warning-logged no-ops so existing configs keep working;--store/--global/--root/--projectunchangedknowledge-mcp debug(doctor) drops the disk-index diagnostics (location/locked/stale) and keeps resolution/kick/watchdog self-query/doc-count/install-recordVerification
gofmt -l .,go vet ./...,go build ./...cleango test ./... -count=19/9 packages PASSmake eval-mock18/18 PASSprove evals/t/175/175 PASSSearch semantics (query escaping, category/project filters, result merge, scoring) are unchanged; store files remain the single source of truth; cross-process store-file write locking remains out of scope.