AWS: Ensure "snapshot_tags" is present on AMIs #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the `get_image_by_tags` and introduce a new optional
argument named `required_tags`, which when present will ensure the
`tags` params must contain all of the required ones before searching for
the AMI.
The goal here is to prevent the use of `get_image_by_tags` without
important tags, causing the resulting image to be duplicated.
Then, it changes the `publish` method to ensure the `snapshot_tags` is
always present when searching for image via tags, since we only consider
the snapshot fully imported when this tag is added (see line 638):
```
add_tags("snapshot_tags", extra_kwargs)
```
Without requiring the `snapshot_tags` to be present we may fall in a
situation where the snapshot was not properly created and a bad result
is returned, mainly leading to duplication of the AMIs for different
image types.
Refers to SPSTRAT-615
Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
JAVGan
force-pushed
the
fix_import_snapshot_issue
branch
from
8413c6f to
59fa787
Compare
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 97.44% 96.88% -0.57%
==========================================
Files 3 3
Lines 586 609 +23
==========================================
+ Hits 571 590 +19
- Misses 15 19 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
get_image_by_tagsand introduce a new optional argument namedrequired_tags, which when present will ensure thetagsparams must contain all of the required ones before searching for the AMI.The goal here is to prevent the use of
get_image_by_tagswithout important tags, causing the resulting image to be duplicated.Then, it changes the
publishmethod to ensure thesnapshot_tagsis always present when searching for image via tags, since we only consider the snapshot fully imported when this tag is added (see line 638):Without requiring the
snapshot_tagsto be present we may fall in a situation where the snapshot was not properly created and a bad result is returned, mainly leading to duplication of the AMIs for different image types.Refers to SPSTRAT-615