You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Analyzed usage of modified constants (useIsWalletCompatible, steps.ts)
Reviewed for correctness, security, and repo guidelines
Code Review — 1 note
The change is small and correct. It adds chain 4663 (Robinhood) to WalletChainIncompatible under a new coinbase key, and normalizes both the coinbasewalletevm and baseevm connectors to coinbase. In useIsWalletCompatible.ts:53-56, any wallet resolving to coinbase on chain 4663 returns false, blocking both send and receive — matching the changeset intent. The new normalization keys follow the existing lowercase {name}{vm} pattern (phantomevm, portoevm, trusttron), and since there's no coinbase entry in WalletChainRestricted, no unintended restriction is introduced.
NOTEArchitecture: shared normalization map affects display name packages/ui/src/constants/walletCompatibility.ts:29 — NormalizedWalletName is consumed by both the compatibility check and getWalletDisplayName in utils/steps.ts:29-33. Mapping baseevm → coinbase means a Base-wallet user will now see "Confirm in Coinbase" during transaction steps rather than "Base". That's fine for the compatibility gate (both should be blocked on 4663), but it's a side effect on the display name that may be unintended. If the display distinction matters, the incompatibility check could key off a separate map rather than reusing the display-name normalization. Worth confirming this is acceptable.
Nothing blocking. Otherwise the change is clean and consistent with existing conventions.
pedromcunha
deleted the
pedro/int2-881-prevent-base-wallet-sends-to-robinhood-that-trap-funds
branch
July 10, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.