Skip to content

fix(styles): remove stray top margin on Callout leading headings#370

Merged
ted-palmer merged 10 commits into
mainfrom
ted/int2-277-update-docs-for-dev-dashboard-mvp
Jul 17, 2026
Merged

fix(styles): remove stray top margin on Callout leading headings#370
ted-palmer merged 10 commits into
mainfrom
ted/int2-277-update-docs-for-dev-dashboard-mvp

Conversation

@ted-palmer

Copy link
Copy Markdown
Collaborator

No description provided.

@ted-palmer
ted-palmer requested a review from pedromcunha July 17, 2026 14:30
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Claude finished @ted-palmer's task in 1m 33s —— View job


Code Review — PR #370

  • Read the diff
  • Review the CSS change
  • Post review

Reviewed the single change to style.css (+7/-0). This is a clean, low-risk styling fix. ✅

Summary

Adds a scoped rule so a heading placed as the first child inside a Callout no longer keeps a stray top margin on the deployed build:

.callout .prose > :first-child {
  margin-top: 0;
}

What's good

  • Scoped and specific. Adding .callout bumps specificity above the generic .prose > :first-child reset the comment mentions, so margin-top: 0 should reliably win inside callouts without affecting prose elsewhere.
  • Well-commented. The comment explains why the rule exists (the prose first-child reset losing inside the callout on the deployed build), which is exactly the kind of context that prevents a future "is this still needed?" deletion.
  • Applies uniformly to all callout variants (<Tip>, <Warning>, <Info>, <Note>), which is consistent behavior.

Minor observations (non-blocking)

  • No trailing newline at end of style.css (\ No newline at end of file). This is pre-existing — not introduced by this PR — so nothing to fix here, but worth cleaning up whenever the file is next touched.
  • Indentation. The new block is indented 2 spaces like its neighbors, but this file mixes column-0 and 2-space top-level rules throughout, so it matches the surrounding (inconsistent) style. No change needed.

No correctness or specificity issues found. Change looks good to merge — and it's already been approved.

@ted-palmer
ted-palmer merged commit a829164 into main Jul 17, 2026
4 checks passed
@ted-palmer
ted-palmer deleted the ted/int2-277-update-docs-for-dev-dashboard-mvp branch July 17, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants