Skip to content

Update audit links#367

Merged
ted-palmer merged 1 commit into
mainfrom
ted/int2-785-fix-missing-links-for-settlement-protocol-and-oracle-audit
Jul 15, 2026
Merged

Update audit links#367
ted-palmer merged 1 commit into
mainfrom
ted/int2-785-fix-missing-links-for-settlement-protocol-and-oracle-audit

Conversation

@ted-palmer

Copy link
Copy Markdown
Collaborator

No description provided.

@ted-palmer
ted-palmer requested a review from pedromcunha July 15, 2026 17:43
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Claude finished @ted-palmer's task in 1m 39s —— View job


Code Review — Update audit links

  • Examine the diff (git diff origin/main...HEAD)
  • Review the changed audit links in references/protocol/security.mdx
  • Verify link targets and formatting
  • Post review feedback

This is a focused 2-line change to the Audits table in references/protocol/security.mdx, swapping the Settlement Protocol and Oracle report links from local PDFs to external GitHub links in the relayprotocol/relay-settlement repo. The MDX/table formatting is correct and the %20 encoding on the Oracle filename is valid. A few things worth confirming before merge:

🔴 Confirm the external links are publicly reachable

The new links point to github.com/relayprotocol/relay-settlement/blob/main/docs/audits/.... If that repo is private, these links will 404 for external doc readers — the current local links (/references/protocol/depository/...) work regardless of repo visibility. I wasn't able to verify reachability from this environment (network access is restricted here), so please confirm relay-settlement is public and both files exist at those exact paths:

  • Relay-Settlement-Protocol-Zellic-Audit.pdf
  • Relay Protocol Oracle - Zellic Audit Report.pdf (spaces → %20)

🟡 The local PDFs are now orphaned

After this change, nothing in the docs references these two files anymore (confirmed via grep):

  • references/protocol/depository/relay-settlement-protocol-zellic.pdf (~860 KB)
  • references/protocol/depository/relay-protocol-oracle-zellic.pdf (~808 KB)

They'll still ship in the build as dead weight. If the intent is to move to external hosting, consider removing them:

git rm "references/protocol/depository/relay-settlement-protocol-zellic.pdf" \
       "references/protocol/depository/relay-protocol-oracle-zellic.pdf"

Fix this → — but only if you're confident the external repo is public and stable; otherwise keeping the local copies as the source of truth is the safer call.

🟢 Minor: table now mixes local and external links

The Audits table now has 3 external GitHub links (Spearbit, Settlement, Oracle) and 1 local link (Certora, June 2025). Not a blocker — Spearbit already used an external link, so there's precedent — but for consistency you may eventually want Certora pointed at its canonical source too.

Nothing here blocks merge from a docs-quality standpoint; the main ask is verifying the target repo is public so readers don't hit a 404.

@mintlify

mintlify Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟢 Ready View Preview Jul 15, 2026, 5:45 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@ted-palmer
ted-palmer merged commit 1fea003 into main Jul 15, 2026
4 checks passed
@ted-palmer
ted-palmer deleted the ted/int2-785-fix-missing-links-for-settlement-protocol-and-oracle-audit branch July 15, 2026 17:49
@mintlify

mintlify Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟡 Building Jul 15, 2026, 5:43 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants