Skip to content

ENG-12577: Align docs breadcrumbs with public canonical URLs - #7221

Merged
carlosabadia merged 2 commits into
mainfrom
carlos/eng-12577-docs-seo
Sep 21, 2026
Merged

carlosabadia merged 2 commits into
mainfrom
carlos/eng-12577-docs-seo

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Docs breadcrumb JSON-LD currently derives its origin from the deployment config, producing localhost URLs while canonical tags point to the public site. Reuse the existing DOCS_PROD_BASE (https://reflex.dev/docs) for breadcrumbs, matching the canonical URLs without changing deploy_url, runtime configuration, or routing.

Update the shared mobile menu's Auth link to /docs/enterprise/auth/overview/. Extend the exported SEO test to verify breadcrumb positions, labels, final canonical destination, and membership in the public sitemap. Existing Cloudflare redirects remain unchanged.

Validation:

  • Regression tests reproduced the bad breadcrumb origins and legacy Auth link before the fixes.
  • Docs unit suite: 545 passed, 1 skipped, 6 build-dependent xfails before export; browser suites excluded.
  • Full frontend export succeeds. All 421 published pages pass the canonical, social, Markdown, internal-link and breadcrumb checks; all five post-build SEO checks pass.
  • All 421 docs routes, negotiated Markdown responses and explicit Markdown files pass through the existing Caddy config.
  • Full repository pre-commit passes.

After merge, rebuild the docs image from the merged Reflex source revision and verify the deployed metadata. No image build or deployment has been triggered by this PR.

Review in cubic

@carlosabadia
carlosabadia requested review from a team and Alek99 as code owners September 21, 2026 10:41
@linear-code

linear-code Bot commented Sep 21, 2026

Copy link
Copy Markdown

ENG-12577

@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Sep 21, 2026
@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.

Summary

This PR aligns documentation breadcrumb JSON-LD with the public canonical docs origin and updates the shared mobile Auth navigation destination.

  • Uses DOCS_PROD_BASE for canonical breadcrumb entries regardless of deployment configuration.
  • Extends exported-site SEO validation to check breadcrumb structure, ordering, canonical destinations, and sitemap membership.
  • Points the mobile Auth entry directly to the current enterprise authentication overview and adds regression coverage.
  • Adds the required shared-package bugfix news fragment.

Reviews (1) · Last reviewed commit: "Remove docs breadcrumb news fragment"

@codspeed

codspeed Bot commented Sep 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 17 skipped benchmarks1


Comparing carlos/eng-12577-docs-seo (572f5b4) with main (4cba004)

Open in CodSpeed

Footnotes

  1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

@carlosabadia
carlosabadia merged commit 1c9a15d into main Sep 21, 2026
126 checks passed
@carlosabadia
carlosabadia deleted the carlos/eng-12577-docs-seo branch September 21, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants