Skip to content

ENG-12575: Align shared footer links with canonical comparison pages - #7220

Merged
carlosabadia merged 4 commits into
mainfrom
carlos/eng-12575-footer-canonical
Sep 21, 2026
Merged

carlosabadia merged 4 commits into
mainfrom
carlos/eng-12575-footer-canonical

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Both shared footer variants still link to legacy migration URLs. Align their Comparison section with the marketing site: combine no-code/low-code into /compare/no-code/, use /compare/frameworks/, and use /compare/other-ai-tools/ as the final AI-tools destination.

Validated both rendered footer variants locally. This PR changes only the two footer source files; the dedicated test and changelog fragment were removed to keep the change focused.

Consumers receive this when they update their shared-site dependency and rebuild. No framework routing behavior is changed.

@carlosabadia
carlosabadia requested a review from a team as a code owner September 21, 2026 10:02
@linear-code

linear-code Bot commented Sep 21, 2026

Copy link
Copy Markdown

ENG-12575

@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Sep 21, 2026
@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The destination updates themselves appear correct, but the repository’s required regression coverage and news-fragment requirements should be restored or explicitly waived before merging.

Findings

  1. P2 Regression Coverage Removed
  2. P2 Required News Fragment Removed

Summary

This PR aligns both shared footer variants with the canonical comparison-page navigation:

  • Renames the footer section from “Migration” to “Comparison.”
  • Consolidates no-code and low-code into /compare/no-code/.
  • Updates framework and AI-tool links to their canonical /compare/ destinations.
  • Removes the previously added regression test and package news fragment.

Reviews (3) · Last reviewed commit: "Keep footer URL correction focused on si..."

@codspeed

codspeed Bot commented Sep 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 17 skipped benchmarks1


Comparing carlos/eng-12575-footer-canonical (2d12dd7) with main (4cba004)

Open in CodSpeed

Footnotes

  1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread tests/units/reflex_site_shared/test_footer_destinations.py Outdated
Comment thread packages/reflex-site-shared/src/reflex_site_shared/views/footer.py
@carlosabadia
carlosabadia merged commit fde6436 into main Sep 21, 2026
126 checks passed
@carlosabadia
carlosabadia deleted the carlos/eng-12575-footer-canonical branch September 21, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants