Skip to content

fix: add BACKEND_TIMEOUT error code with proper error handling #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refcell merged 1 commit into from
Feb 1, 2026
Merged

fix: add BACKEND_TIMEOUT error code with proper error handling #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions crates/types/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ pub mod error_codes {
pub const RATE_LIMITED: i64 = -32016;
/// Backend offline error code.
pub const BACKEND_OFFLINE: i64 = -32010;
/// Backend timeout error code.
pub const BACKEND_TIMEOUT: i64 = -32011;
}

/// Error type for the Roxy proxy.
Expand Down Expand Up @@ -58,19 +60,24 @@ impl RoxyError {
match self {
Self::RateLimited { retry_after } => ErrorPayload {
code: error_codes::RATE_LIMITED,
message: format!("rate limited, retry after {:?}", retry_after).into(),
message: format!("rate limited, retry after {retry_after:?}").into(),
data: None,
},
Self::BackendOffline { backend } => ErrorPayload {
code: error_codes::BACKEND_OFFLINE,
message: format!("backend {} is offline", backend).into(),
message: format!("backend {backend} is offline").into(),
data: None,
},
Self::NoHealthyBackends => ErrorPayload {
code: error_codes::BACKEND_OFFLINE,
message: "no healthy backends".into(),
data: None,
},
Self::BackendTimeout { backend } => ErrorPayload {
code: error_codes::BACKEND_TIMEOUT,
message: format!("backend {backend} timed out").into(),
data: None,
},
_ => ErrorPayload::internal_error(),
}
}
Expand All @@ -88,7 +95,6 @@ mod tests {

use super::*;

/// Test that should_failover returns the expected value for each error type.
#[rstest]
#[case::rate_limited(RoxyError::RateLimited { retry_after: Duration::from_secs(5) }, false)]
#[case::backend_offline(RoxyError::BackendOffline { backend: "primary".to_string() }, true)]
Expand All @@ -100,10 +106,10 @@ mod tests {
assert_eq!(error.should_failover(), expected);
}

/// Test that to_error_payload returns the expected error code for each error type.
#[rstest]
#[case::rate_limited(RoxyError::RateLimited { retry_after: Duration::from_secs(5) }, error_codes::RATE_LIMITED)]
#[case::backend_offline(RoxyError::BackendOffline { backend: "primary".to_string() }, error_codes::BACKEND_OFFLINE)]
#[case::backend_timeout(RoxyError::BackendTimeout { backend: "slow".to_string() }, error_codes::BACKEND_TIMEOUT)]
#[case::no_healthy_backends(RoxyError::NoHealthyBackends, error_codes::BACKEND_OFFLINE)]
#[case::cache_error(RoxyError::CacheError("connection failed".to_string()), -32603)]
#[case::internal_error(RoxyError::Internal("unexpected state".to_string()), -32603)]
Expand All @@ -112,7 +118,6 @@ mod tests {
assert_eq!(payload.code, expected_code);
}

/// Test that error Display messages contain expected substrings.
#[rstest]
#[case::rate_limited(RoxyError::RateLimited { retry_after: Duration::from_secs(5) }, "rate limited")]
#[case::backend_offline(RoxyError::BackendOffline { backend: "primary".to_string() }, "primary")]
Expand All @@ -129,7 +134,6 @@ mod tests {
);
}

/// Test that backend offline error payload message contains the backend name.
#[rstest]
#[case::primary("primary")]
#[case::secondary("secondary")]
Expand All @@ -144,4 +148,19 @@ mod tests {
backend_name
);
}

#[rstest]
#[case::primary("primary")]
#[case::secondary("secondary")]
#[case::node_1("node-1")]
fn test_backend_timeout_payload_contains_name(#[case] backend_name: &str) {
let err = RoxyError::BackendTimeout { backend: backend_name.to_string() };
let payload = err.to_error_payload();
assert!(
payload.message.contains(backend_name),
"Expected payload message '{}' to contain '{}'",
payload.message,
backend_name
);
}
}
Loading