metrics/prometheus: rename histogram timings from _ns to _seconds#4546
metrics/prometheus: rename histogram timings from _ns to _seconds#4546squiidz wants to merge 1 commit into
Conversation
|
Commits Review LGTM |
When use_histogram_timing is true, timing metrics are recorded in
seconds but were still exported under their _ns name. This both
misreported the unit and, in a fleet with mixed use_histogram_timing
settings, caused the same metric name to be sent as two Prometheus
kinds (summary vs histogram). Remote-write targets such as Vector and
Mimir reject the whole batch in that case ("multiple metric kinds
given for metric name"), dropping data and adding backpressure.
Rewrite a trailing _ns suffix to _seconds in histogram mode so the
histogram series (e.g. processor_latency_seconds) is distinct from the
summary series (processor_latency_ns) and the unit suffix is correct.
Fixes INC-1095.
a0fff16 to
8525612
Compare
|
Commits Review The change is correct and well-scoped: metric-name validation in LGTM |
When use_histogram_timing is true, timing metrics are recorded in seconds but were still exported under their _ns name. This both misreported the unit and, in a fleet with mixed use_histogram_timing settings, caused the same metric name to be sent as two Prometheus kinds (summary vs histogram). Remote-write targets such as Vector and Mimir reject the whole batch in that case ("multiple metric kinds given for metric name"), dropping data and adding backpressure.
Rewrite a trailing _ns suffix to _seconds in histogram mode so the histogram series (e.g. processor_latency_seconds) is distinct from the summary series (processor_latency_ns) and the unit suffix is correct.
Fixes INC-1095.