public/service: expose collapsed count helpers for plugin developers#396
Open
public/service: expose collapsed count helpers for plugin developers#396
Conversation
|
Commits Review LGTM |
Contributor
|
API change @Jeffail PTAL |
Adds Message.WithCollapsedCount and MessageBatch.CollapsedCount methods to the public service package so that plugin developers can properly set collapsed counts for output metrics when implementing batch-collapsing processors like archive. Closes redpanda-data/connect#1877 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Commits Review LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Message.WithCollapsedCount(count int)method to indicate a message is the result of collapsing multiple messages into oneMessageBatch.CollapsedCount()method to get the total collapsed count across a batchbatch.CtxWithCollapsedCount/batch.CtxCollapsedCountfunctions, enabling plugin developers to properly set collapsed counts for accurateoutput_sent/output_batch_sentmetrics when implementing batch-collapsing processors (like archive)WithCollapsedCount(3)thenWithCollapsedCount(2)yields 4 (base + count - 1 to avoid double-counting)Test plan
WithCollapsedCountandCollapsedCountcovering default, set, accumulation, and multi-message batchpublic/servicetests passCloses redpanda-data/connect#1877
🤖 Generated with Claude Code