Repository navigation
test: time rexdiff on large repositories, and add library benchmarks - #20
Merged
Merged
Conversation
rednafi
force-pushed
the
rel/3-limit-tests
branch
2 times, most recently
from
October 29, 2026 16:45
a41b9f3 to
638040f
Compare
rednafi
force-pushed
the
rel/4-perf
branch
2 times, most recently
from
October 29, 2026 17:04
1326828 to
704f823
Compare
rednafi
force-pushed
the
rel/3-limit-tests
branch
from
October 29, 2026 17:04
638040f to
d0e829f
Compare
… settled library API Diff - Use znkr.io/diff in place of go-udiff. Diffs match git, also for large rewrites. A file over 10,000 lines uses the fast diff. - A file version over 2,000,000 bytes or 50,000 lines shows "file too large to show". A diff holds at most 128 MiB of text, and a change of more than 20,000 files shows only the count. Speed - Render lines only when they come into view, and highlight in the background with time limits. Slow lexers and very long lines show plain. - Read blobs in parallel with a cache. List files, watch, and load the commit picker off the UI goroutine. Reloads wait less after an edit. - Cap Markdown size, depth and work, PR text, find, and grep, so no input freezes the UI. Layout - A narrower file list, the full path above the diff, a thinner separator and gutter, and no rule above the footer. - The left arrow closes an expanded fold. The hover tooltip is gone. Fixes - Scroll through a wrapped line taller than the pane. Keep the cursor visible in a one-row body and in a tall rendered block. - Show invisible characters in names and code, and cut wide names to the list width. - ] and [ step over removed blocks in rendered Markdown. - The PR tab counts every check, and names the failed ones. - Send a review over 64 KB in parts. - -log files are private, hold no typed text, and a FIFO with no reader fails at once. - -check validates -scope and -layout. A branch with no commits, a binary file, and tiny panes show clear notes. - A file created and deleted around a reload leaves the list. API - diff: real Row, Fold, Kind and Side types; RenderFile takes FileOptions; SplitLines; always lazy. - vcs: PR with Tally, File.Err, TooManyFilesError.Count, Watcher.Reset. - rex: New and update.NewInstaller return (value, ok); Paste sends in parts; update.Restart takes env first. - Code names follow the herdr-reviewr settings (navigator, hunk, scope, allFiles). Settings, keys, flags and resume state are unchanged.
- Black-box tests for Markdown depth and size, tall lines, too many files, large files, PR checks past 100, the setting names, and a private log with no typed text. - Library tests for long lines and the highlighter time limits.
test/e2e.sh builds rexdiff and walks the user guide step by step in its own Rex session, with fake agent, gh, clipboard, editor and browser. It also checks resizes from 1x1 to 300x80, hostile names, a review over 64 KB, and the Rex JSON shapes that the fake rex copies. Each step polls the screen until it is whole and holds the text. It replaces TestRealRex.
- test/perf_test.go times start-up, keys, reloads, memory and idle CPU. It runs only if REXDIFF_PERF names a directory. - Benchmarks for vcs and the file tree.
rednafi
force-pushed
the
rel/3-limit-tests
branch
from
October 29, 2026 17:15
d0e829f to
8911fc0
Compare
test: walk every feature in a real Rex with test/e2e.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU. It runs only if REXDIFF_PERF names a directory.
Stacked on
rel/3-limit-tests. Merge in order.