deps: drop the protobuf upper bound from the vertexai and all extras - #734
Draft
vishal-bala wants to merge 2 commits into
Draft
deps: drop the protobuf upper bound from the vertexai and all extras#734vishal-bala wants to merge 2 commits into
vishal-bala wants to merge 2 commits into
Conversation
`protobuf>=5.28.0,<6.0.0` was declared in the `vertexai` extra and copied into `all`, with no comment explaining either bound. It was tighter than the dependency it existed to serve: google-cloud-aiplatform accepts `protobuf>=3.20.2,<7.0.0` on both its current 1.x and 2.x lines, so RedisVL was excluding two major lines the vendor is happy with. RedisVL itself imports no protobuf symbol -- `grep -rn 'protobuf' redisvl/` returns nothing -- so there was no API surface here to protect. The only effect was to constrain resolution for every `redisvl[all]` and `redisvl[vertexai]` user, which conflicts with current grpcio, opentelemetry and google-genai stacks. Keep the floor and let google-cloud-aiplatform express its own ceiling, which is the constraint that tracks reality without needing maintenance here. Resolution is unchanged today: protobuf still locks at 5.29.6, because google-cloud-aiplatform's own bound is what selects it. The lockfile diff is the two `requires-dist` specifiers and nothing else. Relocked with uv 0.12.3 to match UV_VERSION in the workflows; a different uv version rewrites unrelated environment markers throughout the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
vertexaiextra declaredprotobuf>=5.28.0,<6.0.0, copied verbatim intoall, with no comment explaining either bound. The cap was tighter than the dependency it existed to serve:google-cloud-aiplatformacceptsprotobuf>=3.20.2,<7.0.0on both its current 1.x and 2.x lines, so RedisVL excluded two major lines the vendor accepts.RedisVL imports no protobuf symbol anywhere, so the cap protected no API surface here. Its only effect was to narrow resolution for every
redisvl[all]andredisvl[vertexai]user, which conflicts with current grpcio, opentelemetry and google-genai stacks.Changes
The upper bound is removed from both the
vertexaiextra andall. The floor is retained, since it predates this change and a floor carries none of the same cost. A comment now records why there is no ceiling, so the cap is not reinstated by reflex: the package that actually uses protobuf is the one that should express its bound, and it does.Resolution is unchanged. protobuf still locks at 5.29.6, because
google-cloud-aiplatform's own constraint is what selects it. The lockfile diff is the tworequires-distspecifiers and nothing else.Notes
The lockfile was regenerated with uv 0.12.3 to match
UV_VERSIONin the workflows. A different uv version rewrites environment markers throughout the file, which produced 136 lines of unrelated churn on a first attempt.The comment above
google-cloud-aiplatform>=1.26,<2.0.0in the same block is stale on both of its stated facts: it names 1.162.0 as the latest 1.x, which is now 1.165.1, and it says the 2.0.0 release is yanked for dropping the model-garden modules, where the recorded yank reason is an incorrect version bump and 2.0.1 has since shipped un-yanked with those modules present. Correcting it is left out of this change to keep the diff to one concern.Release Notes
The
protobufupper bound has been removed from thevertexaiandallextras. Installations that previously could not resolve alongside a newer protobuf are no longer constrained by RedisVL;google-cloud-aiplatformcontinues to supply its own bound.