Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
andy-stark-redis
left a comment
There was a problem hiding this comment.
One minor suggestion that might improve the clarity of the lists a bit, but otherwise language and links LGTM.
|
|
||
| 1. Export the certificate with the private key: | ||
|
|
||
| 1. Select **Yes, export the private key**. |
There was a problem hiding this comment.
Just a thought, but maybe consider using unordered lists for these sublists? I know the sublists still represent ordered sequences of instructions, but the numbering starts looking complicated for a procedure with many steps and sub-steps, like this one.
An alternative might be to see if you can use lettered lists for sublists like these. I don't think Markdown supports them directly, but you might be able to do it with some CSS.
There was a problem hiding this comment.
@andy-stark-redis Thank you! I updated the CSS to use lettered sublists. That's how our old docs site worked anyway, so I was happy to try and change it. Does the updated staged preview seem more readable with the lettered sublists?
There was a problem hiding this comment.
@rrelledge Yeah, that's exactly what I was thinking, thanks. Looks great and everyone will benefit from this going forward :-)
Note
Low Risk
Primarily documentation and small CSS tweaks; low risk aside from potential confusion if any certificate requirements are misstated.
Overview
Documentation update: Greatly expands
create-certificates.mdto spell out CA-signed certificate requirements (EKU/key usage, SAN DNS patterns, key size/validity, SHA-1 warning), and adds end-to-end procedures for OpenSSL and Windows AD CS (CSR submission, chain assembly, export/convert to PEM), plus new sections for validation commands, installation steps, and common TLS troubleshooting.Styling: Updates
index.cssto apply distinct list-style types for nested ordered lists in.prose(decimal → lower-alpha → lower-roman → decimal) to improve readability of multi-level steps.Written by Cursor Bugbot for commit 2865968. This will update automatically on new commits. Configure here.