-
Notifications
You must be signed in to change notification settings - Fork 297
DOC-6143 linkable TCE boxes (and related AI stuff) #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add copyCodeBlockLinkToClipboard function to copy code block links to clipboard - Add showCopyLinkFeedback function to show visual feedback when link is copied - Add fallbackCopyLinkToClipboard function for older browsers - Add copy link button to code block headers in tabs/wrapper.html - Update clients-example shortcode calls to use named parameters in strings.md
dwdougherty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes function well and they look good, so 👍🏻 from me. I'll leave this as a comment so that others can weigh in.
cmilesb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Thanks @dwdougherty and @cmilesb ! |
The task crept a bit, so this might have been better broken down into two or more PRs. Anyway, practical results:
?lang=Python, etc), which is useful when you want to link to a tab for a specific language.{{< clients-example >}}:descriptionanddifficulty. These are mainly to inform AI tools about what to expect from an example, but the description is also shown in the box (useful if you've been directed to the box from a link).This changes the layout of the TCE boxes a bit, so we should get agreement that this looks OK and is worth having. Only the Strings data type page currently has the description and difficulty parameters added - if we go ahead with this PR then I'll update the existing examples with these parameters.
All feedback welcome :-)