Skip to content

Conversation

@kaitlynmichael
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

DOC-5845

@mich-elle-luna
Copy link
Collaborator

This work for all the pages I tried, thank you!

@mich-elle-luna mich-elle-luna requested a review from a team November 7, 2025 22:20
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried a few pages from RS, RDI, and MCP server and this mostly seems really good! The only issue I can find is that for YAML and CLI examples that contain comment lines, the "#" character that introduces the comment now gets removed. For example:

In staging, hash character gets removed:

https://redis.io/docs/staging/DOC-5845/integrate/redis-data-integration/installation/install-k8s/#using-a-private-image-registry

https://redis.io/docs/staging/DOC-5845/integrate/redis-mcp/install/#install-the-server-from-source

Existing behaviour is that the hash is kept:

https://redis.io/docs/latest/integrate/redis-data-integration/installation/install-k8s/#using-a-private-image-registry

https://redis.io/docs/latest/integrate/redis-mcp/install/#install-the-server-from-source

I think for the YAML especially, it's probably better if it keeps the hashes in place. However, if this conflicts with something else where the hashes are used as CLI prompts, etc, then we may have a bit of a problem :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants