pkg_tool: Add ability to install packages based off OS version #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_config Fixes a bug where installing JQ for the first time causes messages to reach stdout, which messes with the list of packages to install.
Adds the ability to specify dependencies on an OS version level. The
previous way of working with dependencies is still supported ("osname":
[<list of packages]) and will work as expected. This adds support for
checking the full version, major version, and then a default set of
packages for an OS. An example is below
```json
"rhel": {
"9.6": ["gcc"],
"9": ["g++"],
"default": ["gawk"]
}
```
That will install gcc on 9.6, install g++ on 9.* versions (except 9.6),
and then gawk on all versions (except 9.*).
|
This relates to RPOPC-672 |
dvalinrh
reviewed
Nov 4, 2025
package_tool
Outdated
| if [[ -n "$wrapper_config" ]]; then | ||
| wrapper_pkgs=$(parse_json $wrapper_config $running_os) | ||
| if [[ $? -ne 0 ]]; then | ||
| exit 1 |
dvalinrh
reviewed
Nov 4, 2025
package_tool
Outdated
| fi | ||
| wrapper_pip=$(parse_json $wrapper_config pip) | ||
| if [[ $? -ne 0 ]]; then | ||
| exit $? |
dvalinrh
requested changes
Nov 4, 2025
Contributor
dvalinrh
left a comment
dvalinrh
left a comment
There was a problem hiding this comment.
Documentation updates required.
Error messaging when exiting out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability for
package_toolto install packages based off the OS version instead of solely the OS vendor. This will not change the behavior of only having a list of packages for a vendor.Additionally, the version number can be done via only a major (to cover stuff like the entirety of RHEL 9) or a major/minor version pair to handle specific versions if needed.
Before/After Comparison
Before
The wrapper_config can only differentiate based off the OS vendor.
After
The wrapper_config can differentiate based off OS Vendor and OS version.
Clerical Stuff
This closes #109
Relates to JIRA: RPOPC-672