Conversation
|
This relates to RPOPC-872 |
grdumas
reviewed
Mar 25, 2026
Contributor
grdumas
left a comment
grdumas
left a comment
There was a problem hiding this comment.
Question about the single hardcoded exit_out, plus optional refactoring of attempt_tools_curl() and attempt_tools_wget().
I think at least some reference to test_tools-wrapper as a linked project belongs in the README since it is integral to the functioning of the passmark wrapper.
grdumas
added
the
group_review_lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses error_codes found in test_tools/error_codes to provide more specific error indication.
Before/After Comparison
Before: Returned a 0 or 1, making determination of having to rerun very course
After: Error codes are now bases on test_tools/error_codes, making it easier to limit when we do a rerun of the test.
Also, changed how we load in test_tools, we try curl, git, and wget, to avoid a failure due to the program not
being installed.
Clerical Stuff
This closes #52
Relates to JIRA: RPOPC-872
Testing Performed
scenario file
global:
ssh_key_file: replace_your_ssh_key
terminate_cloud: 1
os_vendor: rhel
results_prefix: documentation
os_vendor: rhel
system_type: aws
cloud_os_id: ami-035032ea878eca201
systems:
system1:
tests: "passmark"
host_config: "m5.xlarge"
csv file generated
Testname,Operations,Start_Date,End_Date
CPU_INTEGER_MATH,11308.477666666666,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_FLOATINGPOINT_MATH,6075.8626372982999,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_PRIME,25.737857519365743,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_SORTING,6044.1112175549915,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_ENCRYPTION,1561.2353118758415,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_COMPRESSION,49482.996629311383,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_SINGLETHREAD,1806.783811132548,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_PHYSICS,513.0180636499947,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_MATRIX_MULT_SSE,2917.7665402382136,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_mm,343.83665038348119,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_sse,1232.2354716647751,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_fma,3659.271431306805,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_avx,2583.1311089885121,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
CPU_avx512,4196.4281489927616,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
m_CPU_enc_SHA,512291001.75296998,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
m_CPU_enc_AES,3943809322.454628,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
m_CPU_enc_ECDSA,455121310.94896895,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
ME_ALLOC_S,1354.8967892590651,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
ME_READ_S,22248.570703124999,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
ME_READ_L,11637.0166015625,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
ME_WRITE,10336.931640625,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
ME_LARGE,12402.666666666666,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
ME_LATENCY,51.850149827299241,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
ME_THREADED,25392.56982421875,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
SUMM_CPU,3975.3374521977503,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
SUMM_ME,2133.6243122691976,2026-03-13T16:43:28Z,2026-03-13T16:46:01Z
Returned 0 as expected. Testing on rerun verification handled in the appropriate zathras pr.