chore: pin techdocs-node to 1.14.4 so that it doesn't use the unavailable toError function#4962
chore: pin techdocs-node to 1.14.4 so that it doesn't use the unavailable toError function#496204kash wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
The container image build workflow finished with status: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4962 +/- ##
==========================================
- Coverage 55.82% 55.25% -0.58%
==========================================
Files 121 109 -12
Lines 2350 2132 -218
Branches 562 536 -26
==========================================
- Hits 1312 1178 -134
+ Misses 1032 953 -79
+ Partials 6 1 -5
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
0b069e2 to
ce8fafd
Compare
|
The container image build workflow finished with status: |
…able toError function Signed-off-by: Kashish Mittal <kmittal@redhat.com>
ce8fafd to
467f6ab
Compare
|
The container image build workflow finished with status: |
|
|
@04kash: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Description
RHDH 1.10 is on Backstage 1.49.4, so the RHDH backend provides
@backstage/errors1.2.7. We were pulling in@backstage/plugin-techdocs-node1.14.5, which callstoError(added in errors 1.3.0). techdocs-node is bundled into the dynamic plugin, but@backstage/errorsis a peerDep — it's not bundled, the RHDH backend provides it at runtime. So techdocs-node's^1.3.0declaration only affects the build workspace; it doesn't upgrade what the backend actually loads.1.14.5 came in through global-header's caret on
@backstage/plugin-search-backend-module-techdocs. Yarn resolved that to 0.4.13, which depends on techdocs-node ^1.14.5, and deduped it with the techdocs wrapper's 0.4.12 pin. techdocs-node 1.14.5 did bump its@backstage/errorsminimum correctly (#33720); the problem is the RHDH backend still serves 1.2.7.Fix
Pin
@backstage/plugin-techdocs-nodeto 1.14.4 via resolutions indynamic-plugins/package.jsonand the techdocs-backend wrapper, then regeneratedynamic-plugins/yarn.lock.Alternative was bumping
@backstage/errorsto ^1.3.0 at the RHDH root.Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Without pinning to 1.14.4, the following error is observed when mkdocs.yaml is not writable:

After pinning (with mkdocs.yaml still being non-writable), the correct warning message is shown: