feat: register adoption insights translation resources in dynamic plugins config#4950
Open
lokanandaprabhu wants to merge 2 commits into
Open
Conversation
…gins config Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4950 +/- ##
=======================================
Coverage 55.82% 55.82%
=======================================
Files 121 121
Lines 2350 2350
Branches 539 539
=======================================
Hits 1312 1312
Misses 1033 1033
Partials 5 5
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Add the missing Alpha wrapper export so dynamic plugin translation resources can resolve adoptionInsightsTranslations at runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
/retest |
2 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this PR fix
Summary
Registers translation resources for the Adoption Insights dynamic plugin in
app-config.dynamic-plugins.yaml, enabling i18n support when the plugin is loaded as a dynamic plugin.Adds the
translationResourcesentry forred-hat-developer-hub.backstage-plugin-adoption-insights:importName:adoptionInsightsTranslationsref:adoptionInsightsTranslationRefThis follows the same pattern used by other RHDH dynamic plugins (e.g. Extensions, Dynamic Home Page).
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer