Skip to content

fix(fab): remove fab plugin completely#4920

Open
ciiay wants to merge 3 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin-2
Open

fix(fab): remove fab plugin completely#4920
ciiay wants to merge 3 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin-2

Conversation

@ciiay

@ciiay ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member

Description

For RHIDP-13680

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci Bot requested review from PatAKnight and psrna June 4, 2026 15:47
@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin-2 branch from b61d2c4 to 3bbff91 Compare June 4, 2026 15:53
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.82%. Comparing base (48ca1bf) to head (cfcf5f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4920   +/-   ##
=======================================
  Coverage   55.82%   55.82%           
=======================================
  Files         121      121           
  Lines        2350     2350           
  Branches      539      563   +24     
=======================================
  Hits         1312     1312           
+ Misses       1033     1032    -1     
- Partials        5        6    +1     
Flag Coverage Δ
rhdh 55.82% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ca1bf...cfcf5f8. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@ciiay

ciiay commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/retest

3 similar comments
@ciiay

ciiay commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@its-mitesh-kumar

Copy link
Copy Markdown
Member

/retest

1 similar comment
@ciiay

ciiay commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/retest

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay

ciiay commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@debsmita1

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay

ciiay commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@ciiay

ciiay commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@debsmita1

Copy link
Copy Markdown
Member

/retest

1 similar comment
@ciiay

ciiay commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/retest

@HusneShabbir HusneShabbir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @teknaS47

@jrichter1

Copy link
Copy Markdown
Member

can you try rebasing first?

@christoph-jerolimov christoph-jerolimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@christoph-jerolimov

Copy link
Copy Markdown
Member

pushed the rebase button

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@christoph-jerolimov

Copy link
Copy Markdown
Member

/retest

@gustavolira

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

1 similar comment
@gustavolira

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

ciiay added 3 commits June 18, 2026 11:43
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin-2 branch from e75ffc5 to cfcf5f8 Compare June 18, 2026 16:00
@openshift-ci openshift-ci Bot removed the lgtm label Jun 18, 2026
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay

ciiay commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

@ciiay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm cfcf5f8 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants