fix(intelligent-assistant): chat UI squashed when opening drawer in overlay/docked modes - #4216
Open
rohitratannagar wants to merge 2 commits into
Conversation
…r opens in overlay/docked modes ChatbotConversationHistoryNav was hardcoded to displayMode=embedded, causing the drawer to render inline and squeeze the chat content. Pass the actual displayMode so the drawer overlays in overlay/docked modes while preserving inline behavior in fullscreen. Resolves: RHDHBUGS-3575 Assisted-by: Claude Opus 4.6 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rohitratannagar
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
August 10, 2026 06:14
Changed Packages
|
PR Summary by QodoFix chat history drawer overlay behavior in overlay/docked modes
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Assisted-by: Claude Opus 4.6 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
=======================================
Coverage 58.33% 58.33%
=======================================
Files 2432 2432
Lines 96776 96776
Branches 26923 26932 +9
=======================================
Hits 56457 56457
Misses 40125 40125
Partials 194 194
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3575
ChatbotConversationHistoryNavwas hardcoded todisplayMode={ChatbotDisplayMode.embedded}, which tells PatternFly to render the drawer panel inline (side-by-side). In overlay/docked modes it should use the actualdisplayModeso the drawer renders as a floating overlay with a backdrop insteaddisplayMode={displayMode}instead of the hardcoded valueBefore / After
Test plan
Resolves: RHDHBUGS-3575
🤖 Generated with Claude Code