feat(#4209): add ai-model-server API spec type extension - #4211
feat(#4209): add ai-model-server API spec type extension#4211fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add two new plugins implementing the ai-model-server spec type for the API kind, replicating the upstream backstage/backstage#34476 schema as an rhdh-plugins module while the upstream PR is pending. catalog-model-ai-model-server provides the AiModelServerApiEntity TypeScript type, JSON schema, KindValidator, type guard, and CatalogModelLayer. The schema requires serverType and serverUrl fields and supports optional requiresApiKey, apiEntityRef, and models (discoverable, available, default). catalog-backend-module-ai-model-server registers the model layer with the catalog via catalogModelExtensionPoint.addModelSource. Includes example YAML, changeset, API reports, and dev backend wiring. Closes #4209 Assisted-by: Claude
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4211 +/- ##
=======================================
Coverage 58.33% 58.33%
=======================================
Files 2432 2434 +2
Lines 96774 96796 +22
Branches 26955 26957 +2
=======================================
+ Hits 56451 56469 +18
+ Misses 40125 40122 -3
- Partials 198 205 +7
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 11:48 PM UTC · Completed 12:07 AM UTC Commit: |
ReviewFindingsMedium
Low
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| ), | ||
| ); | ||
| backend.add(import('@backstage/plugin-catalog-backend-module-ai-model')); | ||
| backend.add( |
There was a problem hiding this comment.
[medium] potential-registration-overlap
The dev backend registers both the upstream @backstage/plugin-catalog-backend-module-ai-model (line 79) and this new catalog-backend-module-ai-model-server module. Both register CatalogModelLayers for the API kind. Once upstream backstage/backstage#34476 merges and adds ai-model-server support, a double-registration conflict could occur.
Suggested fix: Add a code comment clarifying this is a stopgap until upstream backstage/backstage#34476 merges, or open a follow-up issue to track removal.
fullsend-ai-review
Bot
added
the
requires-manual-review
1 participant
Add two new plugins implementing the ai-model-server spec type for the API kind, replicating the upstream backstage/backstage#34476 schema as an rhdh-plugins module while the upstream PR is pending.
catalog-model-ai-model-server provides the AiModelServerApiEntity TypeScript type, JSON schema, KindValidator, type guard, and CatalogModelLayer. The schema requires serverType and serverUrl fields and supports optional requiresApiKey, apiEntityRef, and models (discoverable, available, default).
catalog-backend-module-ai-model-server registers the model layer with the catalog via catalogModelExtensionPoint.addModelSource.
Includes example YAML, changeset, API reports, and dev backend wiring.
Assisted-by: Claude
Closes #4209
Post-script verification
agent/4209-ai-model-server-spec)6c752b60d5bdc359d1eb6b5b81a34880a0c71c21..HEAD)