chore(fullsend): derive yarn binary from yarnPath - #4199
Conversation
PR Summary by QodoFullsend: update RHDH Yarn helper path to 4.17.1
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
New changes are detected. LGTM label has been removed. |
Code Review by Qodo
1.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4199 +/- ##
==========================================
+ Coverage 58.30% 58.33% +0.03%
==========================================
Files 2427 2432 +5
Lines 96721 96775 +54
Branches 26915 26908 -7
==========================================
+ Hits 56390 56455 +65
+ Misses 38869 38852 -17
- Partials 1462 1468 +6
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Keep Fullsend's vendored Yarn path in sync with RHDH and this repo after the 4.17.1 bump so workflows do not look for the removed 4.12.0 binary. https://redhat.atlassian.net/browse/RHIDP-16074 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Update leftover 4.12.0 packageManager/yarnPath references and regenerate install-dynamic-plugins yarn.lock under Yarn 4.17.1. https://redhat.atlassian.net/browse/RHIDP-16074 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
a60cb7f to
5aa6dd6
Compare
|
WIP here to regen the yarn locks for all the workspaces that moved to a new yarn version as the lock file is now on version 10 (4.12 had lockfile version 8). Once yarn locks are regenerated this PR will be updated and should HOPEFULLY pass. |
Read the target repo's .yarnrc.yml yarnPath instead of hardcoding a Yarn release filename, so Fullsend tracks RHDH Yarn bumps automatically. Fall back to a single .yarn/releases/yarn-*.cjs when yarnPath is missing. https://redhat.atlassian.net/browse/RHIDP-16074 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Refresh lockfile metadata (v8 → v10) and builtin resolve patch hashes so `yarn install --immutable` succeeds under Yarn 4.17.1. Leave dcm on its explicit yarn@4.15.0 pin. https://redhat.atlassian.net/browse/RHIDP-16074 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Finished Review · ✅ Success · Started 1:09 PM UTC · Completed 1:22 PM UTC Commit: |
|
Looks good to me Labels: PR modifies .fullsend/ infrastructure and bumps Yarn from 4.12.0 to 4.17.1 with lockfile regeneration Previous runReviewFindingsLow
Previous run (2)Looks good to me |
Yarn 4.17+ defaults enableScripts to false (breaking better-sqlite3 native builds in CI) and npmMinimalAgeGate to 1d. Restore scripts and use a 4h gate. https://redhat.atlassian.net/browse/RHIDP-16074 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Review · ❌ Terminated · Started 1:55 PM UTC · Ended 2:08 PM UTC Commit: |
|
🤖 Finished Review · ✅ Success · Started 1:55 PM UTC · Completed 2:08 PM UTC Commit: |
Document that Fullsend targets the rhdh-plugins checkout (not redhat-developer/rhdh), strip inline YAML comments from yarnPath, and include yarnPath in fallback/error diagnostics. https://redhat.atlassian.net/browse/RHIDP-16074 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Review · ❌ Terminated · Started 2:42 PM UTC · Ended 2:54 PM UTC Commit: |
|
|
🤖 Finished Review · ✅ Success · Started 2:42 PM UTC · Completed 2:54 PM UTC Commit: |
hopehadfield
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this @nickboldt
|
🤖 Finished Retro · ✅ Success · Started 4:41 PM UTC · Completed 4:58 PM UTC Commit: |
Retro: PR #4199 — Fullsend Yarn helper updateOutcome: The workflow went well overall. The review agent produced actionable feedback on a human-authored PR (Cursor-generated by @nickboldt) that updated the Fullsend Yarn wrapper to dynamically derive the yarn executable from Timeline
Evidence for existing issues
Proposals filed
|



Summary
.yarnrc.ymlyarnPath(with a single.yarn/releases/yarn-*.cjsfallback) so Yarn bumps no longer require editing.fullsend/rhdh/bin/yarn.FULLSEND_TARGET_REPO_DIRis this repo’s sandbox checkout, notredhat-developer/rhdh).yarn.lockfiles for Yarn 4.17.1 (__metadatav10), pininstall-dynamic-plugins, fixintelligent-assistantyarnPath, and set rootenableScripts/npmMinimalAgeGatefor 4.17+.Test plan
FULLSEND_TARGET_REPO_DIR=$PWD .fullsend/rhdh/bin/yarn -v→ 4.17.1.yarnrc.ymlhas an inline#comment onyarnPathyarnPathis missing and exactly oneyarn-*.cjsexistsGenerated-by: cursor
Ref: https://redhat.atlassian.net/browse/RHIDP-16074