feat(homepage): add unless exclusion and tags for RBAC conditional filtering#3546
Open
karthikjeeyar wants to merge 1 commit into
Open
feat(homepage): add unless exclusion and tags for RBAC conditional filtering#3546karthikjeeyar wants to merge 1 commit into
unless exclusion and tags for RBAC conditional filtering#3546karthikjeeyar wants to merge 1 commit into
Conversation
karthikjeeyar
requested review from
a team,
Eswaraiahsapram and
christoph-jerolimov
as code owners
Contributor
|
This pull request adds a new top-level directory under |
karthikjeeyar
force-pushed
the
homepage/unless-and-tags
branch
from
153460c to
31443ff
Compare
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
karthikjeeyar
force-pushed
the
homepage/unless-and-tags
branch
from
31443ff to
0c8d4c8
Compare
karthikjeeyar
changed the title
unless exclusion and tags for RBAC conditional filtering
karthikjeeyar
force-pushed
the
homepage/unless-and-tags
branch
from
0c8d4c8 to
cfc411a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3546 +/- ##
==========================================
+ Coverage 53.74% 53.75% +0.01%
==========================================
Files 2268 2269 +1
Lines 86468 86500 +32
Branches 24268 24279 +11
==========================================
+ Hits 46468 46499 +31
- Misses 39774 39775 +1
Partials 226 226
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…ltering Signed-off-by: Karthik <karthik.jk11@gmail.com>
karthikjeeyar
force-pushed
the
homepage/unless-and-tags
branch
from
cfc411a to
5147ac1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes:
https://redhat.atlassian.net/browse/RHIDP-14648
https://redhat.atlassian.net/browse/RHIDP-14649
Adds two new config-level features to homepage default widgets:
unlessconfig block: inverse ofif— uses the same shape (users,groups,permissions) but acts as a denylist. Checked beforeifso deny always wins. On group nodes, prunes the entire subtree.tagson widget nodes: optional string array (e.g.['admin', 'developer']) passed through to the API response. Used with the newHAS_TAGpermission rule for RBAC conditional policy filtering. Widgets without tags bypass tag-based filtering.HAS_TAGpermission rule: new rule registered alongsideHAS_WIDGET_IDfor thehomepage-default-widgetresource type. Matcheswidgets that have at least one overlapping tag.
authorizeConditionalfrombuildUserContextintoDefaultWidgetsServiceso the top-level RBAC filtering runs.unless,tags, filtering layer and permission rules table.{ ...mountPoint.config?.props, ...widget.props }).Screenshots:
How to test
Test widgets included in app-config.yaml, to switch different personas
examples/org.yaml— change the guest user's memberOf to match:conditional-policies.yamltags to filter the widgets.✔️ Checklist