Skip to content

feat(lightspeed): rename config namespace to intelligent-assistant and update rbac policy name#3538

Open
its-mitesh-kumar wants to merge 3 commits into
redhat-developer:mainfrom
its-mitesh-kumar:feat/lightspeed-intelligent-assistant-rebrand
Open

feat(lightspeed): rename config namespace to intelligent-assistant and update rbac policy name#3538
its-mitesh-kumar wants to merge 3 commits into
redhat-developer:mainfrom
its-mitesh-kumar:feat/lightspeed-intelligent-assistant-rebrand

Conversation

@its-mitesh-kumar

@its-mitesh-kumar its-mitesh-kumar commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Rename the configuration namespace from lightspeed to intelligent-assistant across all backend, frontend, and common plugins. Update RBAC permission policy names to use the intelligent-assistant.* prefix.

Fixed

UI after change

configuration namespace from lightspeed to intelligent-assistant

S_.2026-06-23.at.4.09.54.AM.mov

Update RBAC permission policy names to use the intelligent-assistant.* prefix.

S_.2026-06-23.at.3.36.54.AM.mov
S_.2026-06-23.at.3.54.25.AM.mov

Depreciation warning

S_ 2026-06-23 at 5 30 48 AM

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

…d update rbac policy name

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 22, 2026

Copy link
Copy Markdown

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/lightspeed/packages/app none v0.0.27
@red-hat-developer-hub/backstage-plugin-lightspeed-backend workspaces/lightspeed/plugins/lightspeed-backend major v2.9.1
@red-hat-developer-hub/backstage-plugin-lightspeed-common workspaces/lightspeed/plugins/lightspeed-common major v2.9.1
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed major v2.9.1

@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

/cc @JslYoon Please look into backend file changes.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.63%. Comparing base (a32a667) to head (0ac2e64).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3538      +/-   ##
==========================================
- Coverage   53.63%   53.63%   -0.01%     
==========================================
  Files        2260     2260              
  Lines       85976    85981       +5     
  Branches    24203    24196       -7     
==========================================
+ Hits        46117    46119       +2     
- Misses      38314    38317       +3     
  Partials     1545     1545              
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <ø> (ø) Carriedforward from d7672f2
ai-integrations 67.95% <ø> (ø) Carriedforward from d7672f2
app-defaults 69.79% <ø> (ø) Carriedforward from d7672f2
augment 46.39% <ø> (ø) Carriedforward from d7672f2
boost 74.64% <ø> (ø) Carriedforward from d7672f2
bulk-import 72.46% <ø> (ø) Carriedforward from d7672f2
cost-management 14.10% <ø> (ø) Carriedforward from d7672f2
dcm 61.79% <ø> (ø) Carriedforward from d7672f2
extensions 61.53% <ø> (ø) Carriedforward from d7672f2
global-floating-action-button 71.18% <ø> (ø) Carriedforward from d7672f2
global-header 59.71% <ø> (ø) Carriedforward from d7672f2
homepage 49.92% <ø> (ø) Carriedforward from d7672f2
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from d7672f2
konflux 91.49% <ø> (ø) Carriedforward from d7672f2
lightspeed 68.55% <62.50%> (-0.03%) ⬇️
mcp-integrations 85.46% <ø> (ø) Carriedforward from d7672f2
orchestrator 37.79% <ø> (ø) Carriedforward from d7672f2
quickstart 63.76% <ø> (ø) Carriedforward from d7672f2
sandbox 79.56% <ø> (ø) Carriedforward from d7672f2
scorecard 83.96% <ø> (ø) Carriedforward from d7672f2
theme 61.26% <ø> (ø) Carriedforward from d7672f2
translations 7.25% <ø> (ø) Carriedforward from d7672f2
x2a 78.68% <ø> (ø) Carriedforward from d7672f2

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32a667...0ac2e64. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 23, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:25 AM UTC · Completed 11:38 AM UTC
Commit: 94d1d9a · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [silent config loss on upgrade] workspaces/lightspeed/plugins/lightspeed-backend/src/plugin.ts:54 — Users upgrading with the old lightspeed: config key will have their settings silently ignored. The deprecation warning is logged via config.has('lightspeed'), but the plugin proceeds with defaults rather than reading old values or refusing to start. While this is documented as a BREAKING CHANGE with a major version bump, the warn-and-continue pattern can lead to confusing runtime behavior where the app starts successfully but behaves differently than expected (e.g., notebooks disabled, default port, no MCP servers).
    Remediation: Consider throwing an error when old config is detected (refusing to start until migrated), or implement a config fallback that reads from the old key when the new key is absent during a transition period.

  • [intentional breaking change in RBAC permission names] workspaces/lightspeed/plugins/lightspeed-common/src/permissions.ts:23 — Renaming all permission name strings from lightspeed.* to intelligent-assistant.* will cause existing RBAC policies (in databases and CSV files) to stop matching until manually updated. This is properly signaled as a major version bump with a detailed migration guide in the README.
    Remediation: Consider whether a deprecation period with dual-name support would reduce upgrade friction. If the hard cutover is intentional (as the major bump and migration guide suggest), ensure release notes prominently highlight this.

Info

  • [Missing explicit permission check on endpoint] workspaces/lightspeed/plugins/lightspeed-backend/src/service/router.ts:445 — The GET /notebook-conversation-ids endpoint lacks requirePermission() middleware, unlike other data-access endpoints. Pre-existing issue, not introduced by this PR. The endpoint does filter by userEntityRef, providing data isolation.

  • [sub-agent-failure] N/A — The intent-coherence, style-conventions, docs-currency, and cross-repo-contracts sub-agents did not return findings due to model unavailability. These are sonnet-tier dimensions; the opus-tier correctness and security dimensions completed successfully.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant