chore(scorecard): align examples to see all at once#3528
chore(scorecard): align examples to see all at once#3528christoph-jerolimov wants to merge 1 commit into
Conversation
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
|
|
🤖 Finished Review · ✅ Success · Started 10:26 AM UTC · Completed 10:35 AM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3528 +/- ##
=======================================
Coverage 53.63% 53.63%
=======================================
Files 2260 2260
Lines 85972 85972
Branches 24185 24185
=======================================
Hits 46112 46112
Misses 38369 38369
Partials 1491 1491
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Looks good to me |
PR Summary by Qodoscorecard: align example catalog location + component names for one-screen view Description
Diagram
High-Level Assessment
Files changed (11)
|
| spec: | ||
| type: service | ||
| owner: rhdh-team | ||
| owner: group:development/guests |
There was a problem hiding this comment.
I think we wanted to leave at least one scorecard to have owner as a user instead of group to cover that use case. It doesn't necessarily have to be all-scorecards.yaml. Is there any other scorecard covering it?
There was a problem hiding this comment.
Nope. But that was the problem why the catalog switches to show just this catalog.
But I can investigate why it doesn't show everything because the guest user is in both groups.
Thanks for the feedback, will take a look.



Hey, I just made a Pull Request!
yarn startbefore:With this change:
✔️ Checklist