-
Notifications
You must be signed in to change notification settings - Fork 85
feat(lightspeed): Add Developer Lightspeed Chat Popup/Button #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
5165e8f to
b9a69af
Compare
b9a69af to
106856f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debsmita1 Thanks for the PR — the functionality works as expected. I have a few observations:
-
The placeholder text and the alert message below is not in sync with the Figma design.
-
In the chat history sidebar, the New Chat and Close buttons are swapped (for overlay & dock to window modes). The current behavior seems ideal, but it differs from what’s shown in Figma.
-
In both overlay and dock-to-window display modes, pinned chats are listed as collapsible in the Figma design, which appears to be missing in this PR.
-
Tests are failing because the Lightspeed plugin is not present in the navigation sidebar. This might require minor tweaks in the existing tests. /cc @jrichter1
Please take a look and let me know your thoughts.
|
@debsmita1 can you please merge PR debsmita1#3? |
ce76bc0 to
3b7f923
Compare
3b7f923 to
6bdeba3
Compare
Could you share a screenshot ?
As discussed in the UX call, this is a design inconsistency. We should keep the position of the “New Chat” and “Close” buttons the same in every mode
same as above
Thank you for fixing the e2e tests
|
|
@debsmita1 LGTM! Just one question regarding dark mode: it looks like both the light and dark versions of the overlay popup don’t have a shadow, which makes it a bit less visually distinct especially in the dark view. I’ve added a PatternFly example as the second screenshot for reference.
|
HusneShabbir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When switching Lightspeed view from Fullscreen → Dock to Window, it switches to Overlay display mode, which is not the expected behavior.
Attached a video for reference.
Screen.Recording.2026-01-09.at.2.18.39.PM.mov
f46ddd2 to
fe3c69f
Compare
Fixed it and updated the screen recordings above. PTAL ! |
Fixed it and updated the screen recordings |
fe3c69f to
c769117
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on the dev page and in RHDH
Everything works as expected. Great work!
|
lgtm, thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed an inconsistency in behavior when using the Escape (ESC) key while accessing chatbot options.
In overlay mode, pressing ESC currently closes the entire Lightspeed window. The expected behavior is that ESC should only close the chatbot options dialog. If the user presses ESC again, it should then close the Lightspeed window. This would align the behavior in overlay mode with other modes, ensuring consistency across the application.
I’ve attached a video reference for better understanding.








Hey, I just made a Pull Request!
Resolves:
Part of https://issues.redhat.com/browse/RHIDP-9381
Solution description:
- Overlay - Chatbot appears as a floating overlay
- Docked - Chatbot docks to the side of the window
- Fullscreen - Chatbot expands to full screen with a dedicated route, appending the active conversation ID to the URL (if one exists)
- QuickstartDrawerStateExposer - Component to expose partial drawer state, which can be consumed by the ApplicationDrawer in RHDH (feat: add new drawer mount points rhdh#3947)
- Separated Drawer content from the Drawer container for better reusability
GIF:
On rhdh-plugins
Screen.Recording.2026-01-09.at.11.56.25.PM.mov
With active conversation switching to Full-screen mode
Screen.Recording.2026-01-09.at.11.58.05.PM.mov
on RHDH with Quickstarts drawer
Screen.Recording.2026-01-10.at.12.05.32.AM.mov
✔️ Checklist