Skip to content

fix: route TLS trust probe through IDE HTTP proxy (CRW-12333) - #361

Draft
adietish wants to merge 1 commit into
redhat-developer:mainfrom
adietish:crw-12333
Draft

fix: route TLS trust probe through IDE HTTP proxy (CRW-12333)#361
adietish wants to merge 1 commit into
redhat-developer:mainfrom
adietish:crw-12333

Conversation

@adietish

Copy link
Copy Markdown
Collaborator

TlsProbe opened a raw SSLSocket and bypassed IdeHttpProxy, so proxy-only clusters timed out even when Check connection worked. Use the IDE ProxySelector (HTTP CONNECT, Basic on 407) and surface connect failures clearly instead of treating them as trust prompts.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ecbced6-c066-4e9a-8b7c-9007c0659cb7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adietish
adietish force-pushed the crw-12333 branch 2 times, most recently from f3c2c1e to 50b5a29 Compare August 10, 2026 14:17
TlsProbe opened a raw SSLSocket and bypassed IdeHttpProxy, so
proxy-only clusters timed out even when Check connection worked.
Use the IDE ProxySelector (HTTP CONNECT, Basic on 407) and surface
connect failures clearly instead of treating them as trust prompts.

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@adietish
adietish force-pushed the crw-12333 branch 2 times, most recently from 50b5a29 to f3f7133 Compare August 10, 2026 15:48
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.40816% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.82%. Comparing base (71098f6) to head (f3f7133).
⚠️ Report is 415 commits behind head on main.

Files with missing lines Patch % Lines
...at/devtools/gateway/auth/tls/TlsConnectionProbe.kt 67.85% 11 Missing and 16 partials ⚠️
...evtools/gateway/auth/tls/DefaultTlsTrustManager.kt 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #361       +/-   ##
==========================================
+ Coverage   0.00%   34.82%   +34.82%     
==========================================
  Files          4      113      +109     
  Lines         26     4896     +4870     
  Branches       0      941      +941     
==========================================
+ Hits           0     1705     +1705     
- Misses        26     2939     +2913     
- Partials       0      252      +252     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants