fix: route TLS trust probe through IDE HTTP proxy (CRW-12333) - #361
fix: route TLS trust probe through IDE HTTP proxy (CRW-12333)#361adietish wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f3c2c1e to
50b5a29
Compare
TlsProbe opened a raw SSLSocket and bypassed IdeHttpProxy, so proxy-only clusters timed out even when Check connection worked. Use the IDE ProxySelector (HTTP CONNECT, Basic on 407) and surface connect failures clearly instead of treating them as trust prompts. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
50b5a29 to
f3f7133
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 0.00% 34.82% +34.82%
==========================================
Files 4 113 +109
Lines 26 4896 +4870
Branches 0 941 +941
==========================================
+ Hits 0 1705 +1705
- Misses 26 2939 +2913
- Partials 0 252 +252 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TlsProbe opened a raw SSLSocket and bypassed IdeHttpProxy, so proxy-only clusters timed out even when Check connection worked. Use the IDE ProxySelector (HTTP CONNECT, Basic on 407) and surface connect failures clearly instead of treating them as trust prompts.