Add maintainer role for Devvit apps#273
Open
CR29-22-2805 wants to merge 1 commit into
Open
Conversation
a7b5504 to
105788a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #272
💸 TL;DR
This prototypes CLI-side support for a maintainer role on Devvit apps. Owners and designated maintainers would be allowed to upload and publish app versions, while unrelated users would remain unauthorized.
This is intended to reduce deployment bottlenecks for mature, collaboratively maintained apps without granting full app ownership.
📜 Details
Design Doc: N/A
Jira: N/A
This patch adds a shared CLI authorization helper for app write actions and updates the upload/publish commands to use it.
The new helper recognizes three authorization outcomes:
ownermaintainerunauthorizedOwners and maintainers can write app versions. Unauthorized users cannot.
This patch updates:
upload.tsto allow app uploads by owners or maintainers.publish.tsto allow app publishing by owners or maintainers.This is a CLI-side prototype. It assumes app metadata can expose a
maintainerslist or equivalent backend-provided permission source. Backend/proto support and rollback support would need to be implemented separately.🧪 Testing Steps / Validation
Testing:
git diff --check.yarn installfrom the workspace root, but dependency installation failed becausepackages/apps/devvit-dev-bot/package.jsondepends ondevvit@0.13.6-dev, which was not available from the public npm registry.yarn testoryarn lintlocally.✅ Checks